Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: Fix search unnecessarily requiring source files #9129

Closed
wants to merge 6 commits into from

Conversation

Blendify
Copy link
Contributor

Subject: Fixes search summeries not showing when html_copy_source = False

Bugfix

Purpose

This seems to have been a mistake with #4022 the ajax call functions correctly without the source files being included in the build (they are never used).

I have tested this out on several themes and now everything works correctly with html_copy_source = False

Relates

#4022

tk0miya and others added 4 commits April 12, 2021 00:34
This seems to have been a mistake with sphinx-doc#4022 the ajax call functions correctly without the source files being included in the build (they are never used).

I have tested this out on several themes and now everything works correctly with `html_copy_source = False`
@Blendify Blendify changed the base branch from master to 4.0.x April 22, 2021 22:02
@Blendify Blendify changed the base branch from 4.0.x to master April 22, 2021 22:05
@Blendify
Copy link
Contributor Author

I am not sure how to rebase this for 4.0.x but it would be nice if this could go into 4.0.x

@tk0miya
Copy link
Member

tk0miya commented Apr 23, 2021

LGTM. Could you rebase this into the 4.x branch?

@Blendify Blendify changed the base branch from master to 4.x April 23, 2021 16:54
This seems to have been a mistake with sphinx-doc#4022 the ajax call functions correctly without the source files being included in the build (they are never used).

I have tested this out on several themes and now everything works correctly with `html_copy_source = False`
tk0miya added a commit that referenced this pull request Apr 24, 2021
@tk0miya tk0miya closed this Apr 24, 2021
@tk0miya
Copy link
Member

tk0miya commented Apr 24, 2021

Merged manually.

I am not sure how to rebase this for 4.0.x but it would be nice if this could go into 4.0.x

You can do it with git rebase command. In this case, you can do it with git rebase HEAD~1 --onto 4.x (This rebases the last commit (~1 means one commit) to the 4.x branch.

@tk0miya
Copy link
Member

tk0miya commented Apr 24, 2021

Thank you for your contribution as always :-)

@Blendify Blendify deleted the Blendify/html-search-ajax branch May 11, 2021 09:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants