[IMP] util: detect incorrect locale_dirs path #9176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
added
internals:config
internals:internationalisation
type:enhancement
In case the config is incorrect (e.g. wrong relative path), it is silently ignored. This makes it easier for debugging.
tk0miya
approved these changes
May 8, 2021
|
Thank you for update. Merging now. |
|
FYI: I posted #9184 to describe this behavior. |
tk0miya
added a commit
that referenced
this pull request
May 9, 2021
doc: Update CHANGES and docs for PR #9176
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the config is incorrect (e.g. wrong relative path), it is silently ignored.
This makes it easier for debugging.
Subject:
Feature or Bugfix
Purpose
It was not clear to me that the
locale_dirsvariable was relative to the source dir and not to the config path. It took me a long time to detect this was the reason my translations were ignored when building.With this logger, I could have understood the error was in my config file.