Provide more semantic structure for screen-readers #9358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like Lines 625 to 626 in 13d59bc |
|
@astrojuanlu thanks for the tip, I updated the test |
|
@astrojuanlu cool, do we need someone else to review too, or is this good to merge? |
|
@jonels-msft this looks good to me but a Sphinx maintainer needs to review it. Also, someone has to approve the pipelines to run, to verify that we are not missing anything. |
|
Merged. Thank you for your contribution! |
tk0miya
added a commit
that referenced
this pull request
Jul 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Fix menu narration for sceen-readers
Feature or Bugfix
Accessibility bugfix
Purpose
The use of
<p>for submenu captions lacks semantic information. Screen-readers don't narrate the menu correctly. This PR adds role="heading" to the caption as an ARIA landmark.Detail
I don't yet know how to test my changes locally, so there may be errors. Please advise if I got it wrong.
Relates
Fixes #8989
Accessibility technique described in https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA12