Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texinfo: fix emission of @footnote directives. #9390

Merged
merged 3 commits into from
Dec 11, 2021
Merged

texinfo: fix emission of @footnote directives. #9390

merged 3 commits into from
Dec 11, 2021
+13 −1

Conversation

marxin
Copy link
Contributor

@marxin marxin commented Jun 30, 2021

Right now, labels are emitted as part of a @footnote directive.
That results in e.g.

Note1: (@footnote{@w{(1)}
Future versions of GCC may zero-extend...
})

which is incorrect and should be rather:

Note1: (@footnote{Future versions of GCC may zero-extend...})

@marxin
Copy link
Contributor Author

marxin commented Jun 30, 2021

Texinfo documentation for @footnote: https://www.gnu.org/software/texinfo/manual/texinfo/html_node/Footnote-Commands.html

@marxin marxin force-pushed the fix-footnote-in-info branch from 61f839c to 7282e0b Compare June 30, 2021 10:44
tk0miya
tk0miya requested changes Jul 3, 2021
View reviewed changes
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

@tk0miya tk0miya modified the milestones: 4.1.0, 4.2.0 Jul 3, 2021
@marxin
texinfo: fix emission of @footnote directives.
1227799 
Right now, labels are emitted as part of a @footnote directive.
That results in e.g.

Note1: (@footnote{@w{(1)}
Future versions of GCC may zero-extend...
})

which is incorrect and should be rather:

Note1: (@footnote{Future versions of GCC may zero-extend...})
@marxin marxin force-pushed the fix-footnote-in-info branch from 7282e0b to 1227799 Compare July 12, 2021 07:21
@marxin
Copy link
Contributor Author

marxin commented Aug 5, 2021

@tk0miya May I please remind this pull request where I asked some questions?

@tk0miya tk0miya modified the milestones: 4.2.0, 4.3.0 Sep 12, 2021
@tk0miya tk0miya modified the milestones: 4.3.0, 4.4.0 Nov 9, 2021
@tk0miya
Merge branch '4.x' into fix-footnote-in-info
5563f67
@tk0miya
refactor: texinfo: Remove CR char from output
8e23b03 
The CR character was added for readability of output.  But it makes the
texinfo writer a bit complicated.  This removes it from output to keep
our code simple (reducing conditions).
@tk0miya tk0miya merged commit d743f21 into sphinx-doc:4.x Dec 11, 2021
@tk0miya
Copy link
Member

tk0miya commented Dec 11, 2021

Merged. Thank you for your contribution!

tk0miya added a commit that referenced this pull request Dec 11, 2021
@tk0miya
Update CHANGES for PR #9390
dbbf5ae
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2022
@marxin marxin deleted the fix-footnote-in-info branch September 9, 2022 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tk0miya tk0miya

Assignees
No one assigned
Labels
builder:texinfo type:bug
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marxin @tk0miya