Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images aren't copied over anymore after upgrade to 4.1.0 #9437

Closed
ahill187 opened this issue Jul 12, 2021 · 2 comments
Closed

Images aren't copied over anymore after upgrade to 4.1.0 #9437

ahill187 opened this issue Jul 12, 2021 · 2 comments
Labels

Comments

@ahill187
Copy link

ahill187 commented Jul 12, 2021

Describe the bug

After upgrading to Sphinx 4.1.0, our logo file is not being properly copied over. When we build our docs, the logo is missing. This was working perfectly fine before the upgrade.

We noticed that for our conf.py file with this line:

html_logo = './_static/img/sct_logo_blue.png'

the resulting path in the rendered version is:

'../_static/../imgs/sct_logo_blue.png'

Note how the folder name was changed from img to imgs?

How to Reproduce

$ git clone https://github.com/spinalcordtoolbox/spinalcordtoolbox
$ cd spinalcordtoolbox/documentation
$ pip install sphinx
$ pip install -r requirements.txt
$ make html

Expected behavior

No response

Your project

https://github.com/spinalcordtoolbox/spinalcordtoolbox

Screenshots

sphinx

OS

Mac

Python version

3.6.12

Sphinx version

4.1.0

Sphinx extensions

No response

Extra tools

No response

Additional context

No response

@ViktorHaag
Copy link
Contributor

Duplicated in #9438 -- I'm happy to close mine if you want, or we can close this one as a duplicate?

@ahill187
Copy link
Author

Duplicated in #9438 -- I'm happy to close mine if you want, or we can close this one as a duplicate?

Oh I didn't see that, sure we can close this one as a duplicate!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants