Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http url not working with html_logo #9444

Closed
PhilipMay opened this issue Jul 13, 2021 · 3 comments
Closed

http url not working with html_logo #9444

PhilipMay opened this issue Jul 13, 2021 · 3 comments
Labels
builder:html type:bug
Milestone
4.1.1

Comments

@PhilipMay
Copy link

Describe the bug

If I provide html_logo in the config and pass an http url then it adds a prefix called __static/ which breaks the link.

How to Reproduce

Expected behavior

Your project

Screenshots

OS

linux

Python version

3.8

Sphinx version

4.1.0

Sphinx extensions

Extra tools

Additional context
@astrojuanlu
Copy link
Contributor

Is this a duplicate of #9438?

@PhilipMay
Copy link
Author

PhilipMay commented Jul 13, 2021 •
edited

Is this a duplicate of #9438?

From the description point of view: no

From code (fixing) point of view: maybe

@tk0miya tk0miya added this to the 4.1.1 milestone Jul 13, 2021
@tk0miya tk0miya closed this as completed Jul 13, 2021
@tk0miya
Copy link
Member

tk0miya commented Jul 13, 2021

Fixed by #9440. I'll ship a bugfix release within a day.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
builder:html type:bug
Projects
None yet
Milestone
4.1.1
Development

No branches or pull requests
3 participants
@PhilipMay @astrojuanlu @tk0miya