texinfo: simplify reference emission. #9578
Merged
+36
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marxin
force-pushed
the
texinfo-add-texinfo_emit_document_references
branch
3 times, most recently
from
1186c21 to
07c93ee
Compare
jakobandersen
added
builder:texinfo
type:enhancement
jakobandersen
requested changes
Nov 6, 2021
Would it make sense to update that FAQ entry to mention this new confval? As for the core part of this, I unfortunately don't know enough about texinfo to review it. |
marxin
force-pushed
the
texinfo-add-texinfo_emit_document_references
branch
2 times, most recently
from
640a08e to
fc545ee
Compare
Yes, it makes fully sense and I've just done that. |
marxin
force-pushed
the
texinfo-add-texinfo_emit_document_references
branch
2 times, most recently
from
6dec70e to
f7d2eed
Compare
|
I'll merge this into 4.3.0 release if @jakobandersen approves until X-Day. |
jakobandersen
approved these changes
Nov 8, 2021
Approved :-), my change request was just to get the |
Thanks for the approval. |
The commit adds a new config value 'texinfo_emit_document_references' that blocks the emission of inline references and make it better readable with legacy stand-alone reader ``info``. Before the change we emit: Default option value for @ref{e,,-Wshift-overflow3}. while with texinfo_emit_document_references == True: Default option value for -Wshift-overflow3. It addresses limitations mentioned in Sphinx' FAQ: https://www.sphinx-doc.org/en/master/faq.html#texinfo-info
marxin
force-pushed
the
texinfo-add-texinfo_emit_document_references
branch
from
f7d2eed to
9ec829f
Compare
|
Rebased for |
|
Merged. Thank you for your contribution! |
tk0miya
added a commit
that referenced
this pull request
Dec 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit adds a new config value 'texinfo_emit_document_references'
that blocks emission of inline references and make it better readable
with legacy stand-alone reader
info.Before the change we emit:
Default option value for @ref{e,,-Wshift-overflow3}.
while with texinfo_emit_document_references == True:
Default option value for -Wshift-overflow3.
It addresses limitations mentioned in Sphinx' FAQ:
https://www.sphinx-doc.org/en/master/faq.html#texinfo-info