Fix download file with special characters #9670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonppe
force-pushed
the
fix-download-file-with-special-characters
branch
from
8cea5a3
to
857d946
Compare
tk0miya
reviewed
Sep 24, 2021
added 2 commits
September 24, 2021 20:34
Add test to make sure Sphinx uses proper URL encoding for special characters in file names. Use test_html_download() since it test_html5_output() doesn't quite seem to have easy pattern to verify the contents of href attribute. Issue sphinx-doc#3097 Signed-off-by: Johannes Aalto <ext-johannes.aalto@vaisala.com>
Properly encode links to files with special characters for the user to actually be able to download them. The issue still remains for image files but the logic path is quite different than with other files fix might involve changes to docutils. Fixes sphinx-doc#3097 Signed-off-by: Johannes Aalto <ext-johannes.aalto@vaisala.com>
jonppe
force-pushed
the
fix-download-file-with-special-characters
branch
from
857d946
to
b2bd115
Compare
tk0miya
approved these changes
Sep 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Fix encoding special characters in download filenames
Bugfix
Purpose
Relates
#3097