Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print file extension twice in linkcheck warnings #9678

Merged
merged 1 commit into from Sep 30, 2021

Conversation

hoefling
Copy link
Contributor

Subject: Fix duplicate .rst extension printed in linkcheck warnings

Feature or Bugfix

  • Bugfix

Purpose

This is just a cosmetic fix.

Right now, linkcheck emits

file.rst.rst:1: WARNING: broken link: https://example.com

With this PR, the file extension is not printed twice, so the warning is emitted like this:

file.rst:1: WARNING: broken link: https://example.com

@hoefling hoefling changed the base branch from 4.x to master September 26, 2021 20:26
@tk0miya tk0miya added this to the 4.3.0 milestone Sep 27, 2021
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you rebase this into the 4.x branch? Then I'll merge this soon.

Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
@hoefling hoefling changed the base branch from master to 4.x September 27, 2021 20:13
@hoefling
Copy link
Contributor Author

@tk0miya done!

@tk0miya tk0miya merged commit ea8b3d3 into sphinx-doc:4.x Sep 30, 2021
tk0miya added a commit that referenced this pull request Sep 30, 2021
@hoefling hoefling deleted the fix-linkcheck-warnings branch October 1, 2021 07:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants