LaTeX: fix '\raggedright' escaping causing "aggedright" text #9737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sphinx version 4.0 introduced a bug in handling hlists in its LaTeX backend. Due to improper backslash escaping, LaTeX "\raggedright" command gets written as Carriage Return character (0x0D) followed by "aggedright". This results in stray "aggedright" text appearing in the resulting PDF and lack of effect \raggedright was supposed to achieve. Fix this by converting the remaining string to a raw string. This appears to be the only occurrence of such a missing escaping based on a quick grep. Fixes #9734. Fixes: 20884bb: "refactor: LaTeX: Use raw strings for LaTeX macros"
|
Merged. Thank you for your contribution! |
Awesome, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx version 4.0 introduced a bug in handling hlists in its LaTeX backend.
Due to improper backslash escaping,
LaTeX "\raggedright" command gets written as
Carriage Return character (0x0D) followed by "aggedright".
This results in stray "aggedright" text appearing in the resulting PDF
and lack of effect \raggedright was supposed to achieve.
Fix this by converting the remaining string to a raw string.
This appears to be the only occurrence of such a missing escaping
based on a quick grep.
Fixes #9734.
Fixes: 20884bb: "refactor: LaTeX: Use raw strings for LaTeX macros"
Feature or Bugfix