Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When is the next Sphinx release that will contain the latest jquery 3.6.0? #9974

Closed
dmpz23 opened this issue Dec 15, 2021 · 5 comments
Closed
Labels
html theme type:enhancement enhance or introduce a new feature
Milestone

Comments

@dmpz23
Copy link

dmpz23 commented Dec 15, 2021

Describe the bug

Our software team is using Sphinx 4.3.1 to generate python api docs.
Our cybersecurity team is stating that we are using an outdated version of jquery (version 3.5.1) and the outdated version is a security vulnerability.

jquery3.5.1.js is located in the html_static folder.

When will Sphinx upgrade to jquery 3.6.0?

The last time that Sphinx updated its jquery file was in May 2020.

Release 3.0.4 (released May 27, 2020)
Bugs fixed
#7696: html: Updated jQuery version from 3.4.1 to 3.5.1 for security reasons

Thanks in advance,
Dan

How to Reproduce

Generate html from Sphinx 4.3.1 and inspect the \html_static folder for jquery-3.5.1.js.

Expected behavior

A future Sphinx release will generate html files that contain jquery-3.6.0.js in the \html_static folder.

Your project

none

Screenshots

No response

OS

Windows 10

Python version

3.7x

Sphinx version

4.3.1

Sphinx extensions

No response

Extra tools

No response

Additional context

No response

@astrojuanlu
Copy link
Contributor

There are plans to drop jQuery, see #7405 and #9874

@tk0miya tk0miya modified the milestones: 4.3.2, 4.4.0 Dec 15, 2021
@tk0miya
Copy link
Member

tk0miya commented Dec 15, 2021

Thank you for letting us know. No reason to keep it old. Let's upgrade.

BTW, the release blog entry says jquery-3.6.0 does not include a security fix.

This release does not include a security fix, but does have some good bug fixes and improvements.
https://blog.jquery.com/2021/03/02/jquery-3-6-0-released/

Could you ask about the security vulnerability to your cybersecurity team, please? I'd like to upgrade it on v4.3.2 ASAP if jquery-3.5.1 contains a security problem. If not, I'll upgrade it on v4.4.0.

tk0miya added a commit to tk0miya/sphinx that referenced this issue Dec 15, 2021
@tk0miya tk0miya added type:enhancement enhance or introduce a new feature and removed type:bug labels Dec 15, 2021
tk0miya added a commit to tk0miya/sphinx that referenced this issue Dec 15, 2021
@dmpz23
Copy link
Author

dmpz23 commented Dec 15, 2021

@tk0miya - Yes I will ask about the security vulnerability and let you know. Stay tuned.
Dan

@dmpz23
Copy link
Author

dmpz23 commented Dec 15, 2021

The security vulnerability is described as:
jQuery contains commented references to the hijacked domain blindsignals, within the files src/queue/delay.js and test/data/jquery-1.9.1.js (the former referring to a Web Archive version of the original site). Users without awareness of the domain's status could be exposed to unspecified attacks if they attempt to follow the links to the hijacked site.

Since jquery-3.6.0 does not fix this issue, it seems we have to wait for jquery to come up with a fix and then incorporate that into Sphinx.

@tk0miya
Copy link
Member

tk0miya commented Dec 16, 2021

Thank you for detailed info. I found an issue for it: jquery/jquery#4981
I'll update the bundled jQuery after released.

@tk0miya tk0miya modified the milestones: 4.4.0, 4.5.0 Jan 13, 2022
@tk0miya tk0miya modified the milestones: 4.5.0, 5.0.0 Mar 27, 2022
@tk0miya tk0miya closed this as completed in 541fcfc May 8, 2022
tk0miya added a commit that referenced this issue May 8, 2022
Close #9974: html: Updated jQuery version from 3.5.1 to 3.6.0
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
html theme type:enhancement enhance or introduce a new feature
Projects
None yet
Development

No branches or pull requests

3 participants