Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minigallery with multiple files: deduplicate and should not start new rows #1259

Open
Charlie-XIAO opened this issue Feb 15, 2024 · 5 comments

Comments

@Charlie-XIAO
Copy link
Contributor

Charlie-XIAO commented Feb 15, 2024

When using minigallery with multiple files, each file will start a new row. It would be nice if they do not start new rows. Also, it would be nice to remove duplicates if multiple files share a same example. The old behavior can be easily retained by calling minigallery for the files separately.

image

@Charlie-XIAO Charlie-XIAO changed the title minigallery with multiple files should not start new row for each file minigallery with multiple files: deduplicate and should not start new rows Feb 15, 2024
@lucyleeow
Copy link
Contributor

@story645 I thought we fixed the separate lines issue?

The duplicates is known. I don't know if there is an easy fix because the duplicates could come from backreference, so we'd have to dig into the .example file itself, and then we may have to amend the contents of one if e.g., 2 .example files both include an example @larsoner any ideas?

@story645
Copy link
Contributor

@story645 I thought we fixed the separate lines issue?

I think so? Far as I could tell, it was caused by putting each backref file in its own parent div and now everything goes in one div src but I'm not sure if you all have released that yet.

so we'd have to dig into the .example file itself,

One of the things I've been thinking about is if there's any appetite for maintaining the back references in something like a table or graph? And same w/ list of thumbnails -> I'd want to remove the double parsing in the directive.

@lucyleeow
Copy link
Contributor

Yes good point, sorry I saw 'file' and thought of the new directive but you're right, we haven't released yet. I guess it's time for a new release, WDYT @larsoner ?

One of the things I've been thinking about is if there's any appetite for maintaining the back references in something like a table or graph?

That sounds reasonable to me, just a lot of work.

What do you mean by double parsing? Thanks

@story645
Copy link
Contributor

What do you mean by double parsing?

That the directive builds the thumbnail div when the input is a file/glob pattern, and part of building the thumbnail div is parsing the source file for the title.

@lucyleeow
Copy link
Contributor

Oh yes I remember that. It would be good to store the title with the backreference. Agree, backreferences could definitely be improved and table/graph sound like good options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants