fix(lyrics-plus/netease): check correctly for songs

[dompling]

lyrics time matching logic（For example:给我一首歌的时间）lyrics content mismatch

[graphite-app]

Graphite Automations

"Add `custom app` label on custom app(s) related changes" took an action on this PR • (05/10/24)

1 label was added to this PR based on ririxi's automation.

[rxri]

Change your code to align with biome errors. Also run biome formatter on it too.

[rxri]

Suggested change

	let itemId = items.findIndex(val => Utils.normalize(val.album.name) === expectedAlbumName);
	if (itemId === -1) {
	itemId = items.findIndex(val => Math.abs(info.duration - val.duration) < 3000);
	}
	if (itemId === -1) {
	itemId = items.findIndex(val => val.name === cleanTitle);
	}
	const itemId = items.findIndex(val =>
	Utils.normalize(val.album.name) === expectedAlbumName ||
	Math.abs(info.duration - val.duration) < 3000 ||
	val.name === cleanTitle
	);

[dompling]

Thank you for your reply, but there may be an album mismatch, and then there may be a market match for that data, but it's not actually the original lyrics, so it's more accurate to iterate over it

[rxri]

What you did, with these two ifs, can be shortened into the change I proposed. There's no difference - just better looking code

[dompling]

This piece of code does indeed have a more concise and elegant logic, but it only loops once. During this loop, if a condition is met, it terminates. There might be cases where the lyrics match the time condition but the album does not, causing premature termination of the loop. I encountered a situation where a song had a matching duration but mismatched lyrics. Therefore, the ideal scenario would be one condition per loop.

[dompling]

Sure, the translation of the provided code snippet would be:

(Utils.normalize(val.album.name) === expectedAlbumName ||
    Math.abs(info.duration - val.duration) < 3000 ) && val.name === cleanTitle

[rxri]

Then just do how you got it working, however do it inside the items.findIndex and not separate if statements

[dompling]

Thanks for your help

[rxri]

Any update on this? I'm still waiting for implementing the changes