Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dribbblish]: Missing play button for tile entries #1037

Closed
sansmoraxz opened this issue Feb 16, 2024 · 2 comments · Fixed by #1070 · May be fixed by #1077
Closed

[Dribbblish]: Missing play button for tile entries #1037

sansmoraxz opened this issue Feb 16, 2024 · 2 comments · Fixed by #1070 · May be fixed by #1077
Assignees

Comments

@sansmoraxz
Copy link
Contributor

Describe the bug
Missing play icon for title entries on hover.

To Reproduce
Steps to reproduce the behavior:

spicetify config inject_css 1 replace_colors 1 overwrite_assets 1 inject_theme_js 1
spicetify config current_theme Dribbblish color_scheme base

Hover over any of the entry.

Expected behavior

Play icon missing. Should be something like this

image

Screenshots
image

Specifics (please complete the following information):

  • OS: Windows 11
  • Spotify version: 1.2.31.1205
  • Spicetify version: 2.31.3
@sansmoraxz
Copy link
Contributor Author

sansmoraxz commented Feb 16, 2024

I have observed that injecting to user.css the following seems to fix it:

.ButtonInner-medium-iconOnly {
    background-color: var(--background-base);
    color: var(--spice-text);
}

Not sure if it cascades the problem somewhere else.

@sansmoraxz
Copy link
Contributor Author

OK I did some more investigations on this. Here's why I observed.

CSS injection of the buttons are as follows:

css-property field-variable colors-property
color --text-base sidebar
background-color --background-base button-active

Some color schemes such as base, dark, purple, etc, have same values for sidebar and button-active. Either we edit those files to ensure the contrast values make sense (which looks like a lot of effort). Or we inject above CSS, I haven't tested all schemes to check if the css don't break anything but that filed looks promising (until spotify decides to use that classname somewhere else).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants