Export PeerIDFromConnectionState #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was mentioned on Slack that it could useful to have. Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
sorindumitru
requested review from
amartinezfayo,
evan2645 and
azdagron
as code owners
azdagron
approved these changes
May 26, 2023
There was a problem hiding this comment.
Thanks, this has been a long time coming :) When the library was first written, we didn't want to export until we had a chance to maybe determine a better way. But that effort never bore fruit and I myself have copied this half a dozen times into various projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mentioned on Slack that it could useful to have to be able extract the SPIFFE ID from a http.Request strucutre.