Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenShift considerations to the k8s getting started guide? #216

Open
evan2645 opened this issue Apr 13, 2021 · 1 comment
Open

Add OpenShift considerations to the k8s getting started guide? #216

evan2645 opened this issue Apr 13, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@evan2645
Copy link
Member

SPIRE recently received a docs contribution that included some small config snippets that are required in order to run SPIRE in OpenShift. It's currently living on the SPIRE Agent reference docs, which feels like the wrong place.

I noticed that the k8s guide on spiffe.io has a section or two for environment related considerations (e.g. minikube). Perhaps that is the natural place for it? What do you think @sanderson042

Here is the PR that SPIRE took: spiffe/spire#2181

And the doc reference itself: https://github.com/spiffe/spire/blob/master/doc/spire_agent.md#openshift-support

@sanderson042
Copy link
Contributor

Hi @evan2645,

Yes, the Quickstart for Kubernetes page you mentioned would be a decent place to put this info, especially since it already has the Minikube and Kubeadm info as you say.

An alternate location for this info would be the Install SPIRE Agents page which covers Kubernetes in a more general way.

Perhaps ideally this would go into something like a new DEPLOY > Kubernetes Deployment Considerations page. But for now the path of least resistance would be Quickstart for Kubernetes (your suggestion) or Install SPIRE Agents.

Back to you for your thoughts ⚽ . I'm ok with getting assigned this issue when we've decided.

@mchurichi mchurichi added the good first issue Good for newcomers label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants