Confusing documentation in the last SPIRE version 1.5.x about NodeResolver

[idexter]

• Version: 1.5.x
• Platform: Any
• Subsystem: NodeResolver

Hello. I'm new in Spire and started using it since v1.5.0. As I understand, since v1.5.0, NodeResolver plugin was deprecated.
At the same time it still exists in actual version of documentation hosted on: https://spiffe.io/

I have found it at least it these sections:

• https://spiffe.io/docs/latest/spire-about/spire-concepts/#all-about-the-server (in Server Diagram and it's description)
• https://spiffe.io/docs/latest/spire-about/spire-concepts/#a-day-in-the-life-of-an-svid (in Section 10)
• https://spiffe.io/docs/latest/spire-about/spire-concepts/#node-resolution
• https://spiffe.io/docs/latest/spire-about/spire-concepts/#node-resolvers
• https://spiffe.io/docs/latest/spire-about/spire-concepts/#node-attestation (in the last paragraph)
• https://spiffe.io/docs/latest/planning/extending/#node-resolver-plugins
• https://spiffe.io/docs/latest/deploying/configuring/#configuring-node-attestation
• https://spiffe.io/docs/latest/deploying/configuring/#google-compute-engine-instances
• https://spiffe.io/docs/latest/deploying/configuring/#amazon-ec2-instances
• https://spiffe.io/docs/latest/deploying/configuring/#azure-virtual-machines
• https://spiffe.io/docs/latest/deploying/registering/#1-defining-the-spiffe-id-of-the-agent

My questions are:

• Is it possible to add custom node selectors since v1.5.0 without forking existing NodeAttestors?
• It it possible to remove that confusing information from documentation and maybe add a new section which explains ways to add custom node selectors?

Thanks

[MarcosDY]

as you mention it is no possible to add custom selectors from v1.5.0,
do you have a use case for that?

About spiffe.io, we'll need to update that documentation, thanks for your summary!!!

[idexter]

do you have a use case for that?

Thanks for the explanation. 🙏 Right now I'm not sure, but most likely it appears in my case the near future. If it happens I will come back and share it.

[evan2645]

Hi @idexter!

Is it possible to add custom node selectors since v1.5.0 without forking existing NodeAttestors?

You should be able to embed the upstream node attestor into a custom one (i.e. wrap it), to inject custom selectors without having to fully fork the attestor. I opened this related issue: spiffe/spire-plugin-sdk#34

It it possible to remove that confusing information from documentation and maybe add a new section which explains ways to add custom node selectors?

We should definitely remove the stale documentation. I'm going to move this issue to the spiffe.io repo