add an auth token to gh api requests #272
Conversation
peterj
requested review from
sanderson042,
mchurichi,
ajessup,
Andres-GC,
evan2645 and
umairmkhan
as code owners
❌ Deploy Preview for spiffe failed.
|
|
Adding the note here from Slack. For the token, we'd need someone with admin permissions on the repo to create a fine-grained personal access token for the spiffe.io repo. The permission needed is under Repository permissions -> Contents
|
|
Hi @peterj, thanks for opening this PR!. For some reason I don't see the changes anymore, they seem to have been overwritten by the most recent force push. Sorry for the delay on getting this merged, it looks good to me. We are just trying to get someone with admin access to review this, give a thumbs up and set the token. Would you mind republishing the changes? |
|
I’ll repush and reopen. yeah, we were waiting for someone with admin access
to create the Gh token.
…On Fri, Feb 24, 2023 at 07:12 Maximiliano Churichi ***@***.***> wrote:
Hi @peterj <https://github.com/peterj>, thanks for opening this PR!. For
some reason I don't see the changes anymore, they seem to have been
overwritten by the most recent force push.
Sorry for the delay on getting this merged, it looks good to me. We are
just trying to get someone with admin access to review this, give a thumbs
up and set the token. Would you mind republishing the changes?
—
Reply to this email directly, view it on GitHub
<#272 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACURJ3EBCIBBJAM73GIFXEDWZDFVBANCNFSM6AAAAAAU37BHZQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
There was a problem hiding this comment.
This looks good to me, and I have confirmed that I'm able to set up the token in Netlify's admin interface. A fine-grained personal GitHub token with basic read-only permissions over public repositories works, no more permissions are needed, so this should be harmless. I'll generate a personal token and configure it as soon as we can get this merged in.
Can someone else take a quick look at this please? cc @evan2645 @Andres-GC
This PR adds the Authorization header to the github API requests to minimize the chances of getting rate limited by GH.
Note that for this to work, someone needs to do the following:
GITHUB_TOKENenvironment variable to netlifyResolves #271