Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced authentication #34

Open
igorlesnenko opened this issue Oct 16, 2017 · 4 comments
Open

Advanced authentication #34

igorlesnenko opened this issue Oct 16, 2017 · 4 comments

Comments

@igorlesnenko
Copy link
Member

igorlesnenko commented Oct 16, 2017

Need to implement better token auth system.
Important: if token is provided and it is invalid we need to return error and don't return any data.
Same for websockets: need to disconnect expired/invalid tokens somehow and not allow to create connection

@sneerin
Copy link

sneerin commented Oct 20, 2017

yeah, that would be nice to have

@sneerin
Copy link

sneerin commented Oct 20, 2017

Just walked briefly through the source code, how can I add the JWT authentification instead of your middleware? If I create the new one will it override yours? Do you want us to create a pull request for that?

@igorlesnenko
Copy link
Member Author

igorlesnenko commented Oct 24, 2017

Hi @sneerin!

At the moment, there is no ability to select middlewares or add your own custom middlewares. We have an issue for that: #27

I see two ways to add JWT auth:

  1. Add another default middleware jwt-auth in the framework source.
  2. Use your own JWT middleware outside of the framework

Both cases are depends on the issue: #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants