{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":19836152,"defaultBranch":"master","name":"kork","ownerLogin":"spinnaker","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-05-15T21:37:21.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/7634182?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715363804.0","currentOid":""},"activityList":{"items":[{"before":"9626bc9077cfa9c339111ec329f65e344bdbb7a1","after":"2d682c9129cbcd90d7746b215a138e6708cb3730","ref":"refs/heads/master","pushedAt":"2024-05-10T17:49:12.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependencies): use version 1.19.8 of testcontainers (#1182)\n\nto stay up to date","shortMessageHtmlLink":"chore(dependencies): use version 1.19.8 of testcontainers (#1182)"}},{"before":"c0f943d1e0075fc64af550631049fc39ab2934c6","after":null,"ref":"refs/heads/dependabot/github_actions/gradle/wrapper-validation-action-3","pushedAt":"2024-05-01T13:37:51.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"97ea0d3025f9d903cc3e6310ed0e3811ad9fce65","after":"9626bc9077cfa9c339111ec329f65e344bdbb7a1","ref":"refs/heads/master","pushedAt":"2024-05-01T13:37:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(deps): bump gradle/wrapper-validation-action from 2 to 3 (#1181)\n\nBumps [gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action) from 2 to 3.\n- [Release notes](https://github.com/gradle/wrapper-validation-action/releases)\n- [Commits](https://github.com/gradle/wrapper-validation-action/compare/v2...v3)\n\n---\nupdated-dependencies:\n- dependency-name: gradle/wrapper-validation-action\n dependency-type: direct:production\n update-type: version-update:semver-major\n...\n\nSigned-off-by: dependabot[bot] \nCo-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>","shortMessageHtmlLink":"chore(deps): bump gradle/wrapper-validation-action from 2 to 3 (#1181)"}},{"before":null,"after":"c0f943d1e0075fc64af550631049fc39ab2934c6","ref":"refs/heads/dependabot/github_actions/gradle/wrapper-validation-action-3","pushedAt":"2024-05-01T10:41:35.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"chore(deps): bump gradle/wrapper-validation-action from 2 to 3\n\nBumps [gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action) from 2 to 3.\n- [Release notes](https://github.com/gradle/wrapper-validation-action/releases)\n- [Commits](https://github.com/gradle/wrapper-validation-action/compare/v2...v3)\n\n---\nupdated-dependencies:\n- dependency-name: gradle/wrapper-validation-action\n dependency-type: direct:production\n update-type: version-update:semver-major\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"chore(deps): bump gradle/wrapper-validation-action from 2 to 3"}},{"before":"0bd4ff8f207f8b6e95004d113690bb19f207b7b1","after":"97ea0d3025f9d903cc3e6310ed0e3811ad9fce65","ref":"refs/heads/master","pushedAt":"2024-04-28T02:48:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"dbyron-sf","name":"David Byron","path":"/dbyron-sf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/82477955?s=80&v=4"},"commit":{"message":"fix(artifacts): authenticate against AuthenticatedRequest.getSpinnakerUser in S3ArtifactStoreGetter (#1180)\n\n* chore(build): give local gradle invocations more memory\r\n\r\nThe same amount that github actions uses, to avoid errors like:\r\n\r\nExpiring Daemon because JVM heap space is exhausted\r\nExpiring Daemon because JVM heap space is exhausted\r\n\r\nFAILURE: Build failed with an exception.\r\n\r\n* What went wrong:\r\nGradle build daemon has been stopped: JVM garbage collector thrashing and after running out of JVM memory and after running out of JVM memory\r\n\r\n* fix(artifacts): authenticate against AuthenticatedRequest.getSpinnakerUser in S3ArtifactStoreGetter\r\n\r\ninstead of SecurityContextHolder.getContext() which might be null. Previously\r\nhasAuthorization would only user userId for logging. Now it's used for authentication\r\ntoo. This fixes the bug that https://github.com/spinnaker/kork/pull/1178 demonstrates.","shortMessageHtmlLink":"fix(artifacts): authenticate against AuthenticatedRequest.getSpinnake…"}},{"before":"9df959e94246392bfdc27bde92ca40fe841d94dd","after":"0bd4ff8f207f8b6e95004d113690bb19f207b7b1","ref":"refs/heads/master","pushedAt":"2024-04-27T00:12:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"feat(security): add UserPermissionEvaluator (#1179)\n\nso S3ArtifactStoreGetter can call a username-based hasPermission method.\nFiatPermissionEvaluator has this method, but using FiatPermissionEvaluator in kork would\ncreate a circular dependency.\n\nThe plan is:\n\n- publish a kork jar with UserPermissionEvaluator,\n- consume it in fiat and change FiatPermissionEvaluator to implement UserPermissionEvaluator instead of PermissionEvaluator\n- publish a fiat jar and consume it everywhere\n- change S3ArtifactStoreGetter to use UserPermissionEvaluator to fix the bug that https://github.com/spinnaker/kork/pull/1178 demonstrates\n- publish yet another kork jar and consume it everywhere to fix use of fetchReference in Evaluate Variables stages\n\nCo-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>","shortMessageHtmlLink":"feat(security): add UserPermissionEvaluator (#1179)"}},{"before":"d57eaf41e27937ac3ad6b63c04d5fe085af3d1da","after":"9df959e94246392bfdc27bde92ca40fe841d94dd","ref":"refs/heads/master","pushedAt":"2024-04-27T00:05:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"test(artifacts): demonstrate that S3ArtifactStoreGetter.get does not use AuthenticatedRequest.getSpinnakerUser (#1178)\n\nwhen authenticating with the permission evaluator. It uses\nSecurityContextHolder.getContext() which may be null depending how the context is\npropagated across threads. This is the case in some scenarios during pipeline execution in\norca (e.g. using #fetchReference in an Evaluate Variables stage).","shortMessageHtmlLink":"test(artifacts): demonstrate that S3ArtifactStoreGetter.get does not …"}},{"before":null,"after":"d57eaf41e27937ac3ad6b63c04d5fe085af3d1da","ref":"refs/heads/release-1.34.x","pushedAt":"2024-04-16T21:51:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dbyron-sf","name":"David Byron","path":"/dbyron-sf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/82477955?s=80&v=4"},"commit":{"message":"feature(expressions): fetchReference SpEL function (#1177)\n\nIntroduces a simple SpEL function that returns the reference that was stored\nin the artifact store.\n\nSigned-off-by: benjamin-j-powell \nCo-authored-by: benjamin-j-powell ","shortMessageHtmlLink":"feature(expressions): fetchReference SpEL function (#1177)"}},{"before":"277447d00bc7bb69112fa8a85b612abdb307fba8","after":"d57eaf41e27937ac3ad6b63c04d5fe085af3d1da","ref":"refs/heads/master","pushedAt":"2024-04-06T03:49:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"feature(expressions): fetchReference SpEL function (#1177)\n\nIntroduces a simple SpEL function that returns the reference that was stored\nin the artifact store.\n\nSigned-off-by: benjamin-j-powell \nCo-authored-by: benjamin-j-powell ","shortMessageHtmlLink":"feature(expressions): fetchReference SpEL function (#1177)"}},{"before":"3a6adacf36320f824ae304ade5403fe8ae026d7d","after":"277447d00bc7bb69112fa8a85b612abdb307fba8","ref":"refs/heads/master","pushedAt":"2024-04-02T18:34:38.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependencies): upgrade testcontainers to the latest - 1.19.6 (#1174)","shortMessageHtmlLink":"chore(dependencies): upgrade testcontainers to the latest - 1.19.6 (#…"}},{"before":"a3e98b5c5029699221efbc981714eab57d47e935","after":"3a6adacf36320f824ae304ade5403fe8ae026d7d","ref":"refs/heads/master","pushedAt":"2024-04-02T12:04:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependency): upgrade kotlin to 1.6.21 and unpin kotlinx-coroutines (#1176)\n\nUpgrade kotlin from 1.5.32 to 1.6.21, in order to sync with spring boot 2.6.15.\nUnpinning kotlinx-coroutines, that brings version 1.5.2 as transitive dependency of spring boot 2.6.15. So, effectively no change in kotlinx-coroutines version.\nhttps://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/2.6.15/spring-boot-dependencies-2.6.15.pom","shortMessageHtmlLink":"chore(dependency): upgrade kotlin to 1.6.21 and unpin kotlinx-corouti…"}},{"before":"85fc6b0d2111b413cf98ad75404249ed27ececfa","after":null,"ref":"refs/heads/dependabot/github_actions/softprops/action-gh-release-2","pushedAt":"2024-04-01T18:08:26.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"c153b6a2399dde97c4b2d0d2857393e9c88be6d5","after":"a3e98b5c5029699221efbc981714eab57d47e935","ref":"refs/heads/master","pushedAt":"2024-04-01T18:08:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(deps): bump softprops/action-gh-release from 1 to 2 (#1175)\n\nBumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2.\n- [Release notes](https://github.com/softprops/action-gh-release/releases)\n- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)\n- [Commits](https://github.com/softprops/action-gh-release/compare/v1...v2)\n\n---\nupdated-dependencies:\n- dependency-name: softprops/action-gh-release\n dependency-type: direct:production\n update-type: version-update:semver-major\n...\n\nSigned-off-by: dependabot[bot] \nCo-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>","shortMessageHtmlLink":"chore(deps): bump softprops/action-gh-release from 1 to 2 (#1175)"}},{"before":null,"after":"85fc6b0d2111b413cf98ad75404249ed27ececfa","ref":"refs/heads/dependabot/github_actions/softprops/action-gh-release-2","pushedAt":"2024-04-01T10:11:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"chore(deps): bump softprops/action-gh-release from 1 to 2\n\nBumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2.\n- [Release notes](https://github.com/softprops/action-gh-release/releases)\n- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)\n- [Commits](https://github.com/softprops/action-gh-release/compare/v1...v2)\n\n---\nupdated-dependencies:\n- dependency-name: softprops/action-gh-release\n dependency-type: direct:production\n update-type: version-update:semver-major\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"chore(deps): bump softprops/action-gh-release from 1 to 2"}},{"before":"e823562f7dd449b980708c1562b718c1e9da70e1","after":"c153b6a2399dde97c4b2d0d2857393e9c88be6d5","ref":"refs/heads/master","pushedAt":"2024-03-21T16:10:08.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependencies): upgrade snakeyaml from 1.29 to 1.31 (#1173)\n\nSpring boot 2.6.15 brings in snakeyaml 1.29, which [fails to parse\nyaml](https://github.com/spring-projects/spring-boot/issues/30159#issuecomment-1125969155)\n(including some k8s manifests). It's safe to upgrade beyond 1.29 according to\n[this](https://github.com/spring-projects/spring-boot/issues/32228#issue-136185850.0). However,\nsnakeyaml 1.32 has a\n[feature](https://bitbucket.org/snakeyaml/snakeyaml/issues/547/restrict-the-size-of-incoming-data)\nto restrict the size of incoming data to 3 MB by default\n([PR](https://bitbucket.org/snakeyaml/snakeyaml/pull-requests/22)), and spring boot\nversions <= 3.0.7 are not equipped to modify this. So, use 1.31 in order to avoid the\nlimit till upgrade >= 3.0.7 and to resolve CVE-2022-25857 and CVE-2022-38749.\n\nbefore:\n\n| | +--- org.yaml:snakeyaml:1.29 -> 1.27 (c)\n| +--- org.yaml:snakeyaml:{strictly 1.27} -> 1.27 (c)\n\nafter:\n\n| | +--- org.yaml:snakeyaml:1.29 -> 1.31 (c)\n| +--- org.yaml:snakeyaml:1.31 (c)","shortMessageHtmlLink":"chore(dependencies): upgrade snakeyaml from 1.29 to 1.31 (#1173)"}},{"before":"8513635c4b3c6293d00e0f3fbf12dc99539d95b0","after":"e823562f7dd449b980708c1562b718c1e9da70e1","ref":"refs/heads/master","pushedAt":"2024-03-12T16:57:28.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependency): upgrade spring boot from 2.5.15 to 2.6.15 and spring cloud from 2020.0.x to 2021.0.x (#1134)\n\n* chore(dependency): upgrade spring boot from 2.5.x to 2.6.x and spring cloud from 2020.0.x to 2021.0.x\n\nSpring cloud release 2021.0.x is compatible with spring boot 2.6.x.\nhttps://github.com/spring-cloud/spring-cloud-release/wiki/Supported-Versions#supported-releases\n\nWhile upgrading spring boot 2.6.15 and spring cloud 2021.0.8, encounter below errors in kork-plugins and kork-tomcat modules:\n\n```\n> Task :kork-plugins:compileTestKotlin FAILED\ne: /kork/kork-plugins/src/test/kotlin/com/netflix/spinnaker/kork/plugins/SpringPluginStatusProviderTest.kt: (50, 11): Type mismatch: inferred type is Array but SpringApplication! was expected\ne: /kork/kork-plugins/src/test/kotlin/com/netflix/spinnaker/kork/plugins/SpringPluginStatusProviderTest.kt: (51, 11): Type mismatch: inferred type is ConfigurableEnvironment but Array<(out) String!>! was expected\ne: /kork/kork-plugins/src/test/kotlin/com/netflix/spinnaker/kork/plugins/SpringPluginStatusProviderTest.kt: (52, 9): No value passed for parameter 'environment'\n```\nThe root cause is the deprecation and removal of `org.springframework.boot.context.event.ApplicationEnvironmentPreparedEvent` constructor without `org.springframework.boot.SpringApplication` in spring boot 2.6.x.\nhttps://docs.spring.io/spring-boot/docs/2.5.15/api/org/springframework/boot/context/event/ApplicationEnvironmentPreparedEvent.html\nTo fix this error add mock for `SpringApplication` in `ApplicationEnvironmentPreparedEvent` constructor.\n\n* fix(springfox): add bean postprocessor to fix springfox to work with spring boot 2.6.x\n\nSpringfox may cause application failure with spring boot 2.6.x, if used along with actuators. It is mentioned in [release notes](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.6-Release-Notes#pathpattern-based-path-matching-strategy-for-spring-mvc). The effects are visible in the form of gate test failure with below given error:\n```\nCaused by: org.springframework.context.ApplicationContextException: Failed to start bean 'documentationPluginsBootstrapper'; nested exception is java.lang.NullPointerException: Cannot invoke \"org.springframework.web.servlet.mvc.condition.PatternsRequestCondition.toString()\" because the return value of \"springfox.documentation.spi.service.contexts.Orderings.patternsCondition(springfox.documentation.RequestHandler)\" is null\n\tat app//org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:181)\n\tat app//org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:54)\n\tat app//org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:356)\n\tat java.base@17.0.8.1/java.lang.Iterable.forEach(Iterable.java:75)\n\tat app//org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:155)\n\tat app//org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:123)\n\tat app//org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:937)\n\tat app//org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:586)\n\tat app//org.springframework.boot.SpringApplication.refresh(SpringApplication.java:745)\n\tat app//org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:423)\n\tat app//org.springframework.boot.SpringApplication.run(SpringApplication.java:307)\n\tat app//org.springframework.boot.test.context.SpringBootContextLoader.loadContext(SpringBootContextLoader.java:148)\n\tat app//org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate.loadContextInternal(DefaultCacheAwareContextLoaderDelegate.java:141)\n\tat app//org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate.loadContext(DefaultCacheAwareContextLoaderDelegate.java:90)\n\t... 61 more\nCaused by: java.lang.NullPointerException: Cannot invoke \"org.springframework.web.servlet.mvc.condition.PatternsRequestCondition.toString()\" because the return value of \"springfox.documentation.spi.service.contexts.Orderings.patternsCondition(springfox.documentation.RequestHandler)\" is null\n\tat springfox.documentation.spi.service.contexts.Orderings$8.compare(Orderings.java:112)\n\tat springfox.documentation.spi.service.contexts.Orderings$8.compare(Orderings.java:109)\n\tat com.google.common.collect.ComparatorOrdering.compare(ComparatorOrdering.java:37)\n\tat java.base/java.util.TimSort.countRunAndMakeAscending(TimSort.java:355)\n\tat java.base/java.util.TimSort.sort(TimSort.java:234)\n\tat java.base/java.util.Arrays.sort(Arrays.java:1233)\n\tat com.google.common.collect.Ordering.sortedCopy(Ordering.java:842)\n\tat springfox.documentation.spring.web.plugins.WebMvcRequestHandlerProvider.requestHandlers(WebMvcRequestHandlerProvider.java:57)\n\tat springfox.documentation.spring.web.plugins.DocumentationPluginsBootstrapper$2.apply(DocumentationPluginsBootstrapper.java:138)\n\tat springfox.documentation.spring.web.plugins.DocumentationPluginsBootstrapper$2.apply(DocumentationPluginsBootstrapper.java:135)\n\tat com.google.common.collect.Iterators$6.transform(Iterators.java:783)\n\tat com.google.common.collect.TransformedIterator.next(TransformedIterator.java:47)\n\tat com.google.common.collect.TransformedIterator.next(TransformedIterator.java:47)\n\tat com.google.common.collect.Iterators$ConcatenatedIterator.hasNext(Iterators.java:1333)\n\tat com.google.common.collect.ImmutableList.copyOf(ImmutableList.java:268)\n\tat com.google.common.collect.ImmutableList.copyOf(ImmutableList.java:232)\n\tat com.google.common.collect.FluentIterable.toList(FluentIterable.java:617)\n\tat springfox.documentation.spring.web.plugins.DocumentationPluginsBootstrapper.defaultContextBuilder(DocumentationPluginsBootstrapper.java:111)\n\tat springfox.documentation.spring.web.plugins.DocumentationPluginsBootstrapper.buildContext(DocumentationPluginsBootstrapper.java:96)\n\tat springfox.documentation.spring.web.plugins.DocumentationPluginsBootstrapper.start(DocumentationPluginsBootstrapper.java:167)\n\tat org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:178)\n\t... 74 more\n```\nIn order to fix the issue, adding springfox bean post processor to handle the request of springfox `WebMvcRequestHandlerProvider` class.\n\n* fix(tomcat): refactor to map spinnaker property default.rejectIllegalHeader with spring property server.tomcat.reject-illegal-header\n\nWhile upgrading spring boot 2.6.15 and spring cloud 2021.0.8, encounter below error during execution of WebEnvironmentTest.testTomcatWithIllegalHttpHeaders test under kork-tomcat module:\n```\nDEBUG 164202 --- [o-auto-2-exec-1] o.a.coyote.http11.Http11InputBuffer : Before fill(): parsingHeader: [true], parsingRequestLine: [true], parsingRequestLinePhase: [0], parsingRequestLineStart: [0], byteBuffer.position(): [0], byteBuffer.limit(): [0], end: [0]\nDEBUG 164202 --- [o-auto-2-exec-1] o.a.coyote.http11.Http11InputBuffer : Received [GET /test-controller HTTP/1.1\nAccept: text/plain, application/json, application/*+json, */*\nX-Dum@my: foo\nUser-Agent: Java/11.0.2\nHost: localhost:35189\nConnection: keep-alive\n\n]\nINFO 164202 --- [o-auto-2-exec-1] o.apache.coyote.http11.Http11Processor : Error parsing HTTP request header\n Note: further occurrences of HTTP request parsing errors will be logged at DEBUG level.\n\njava.lang.IllegalArgumentException: The HTTP header line [x-dum@my: foo] does not conform to RFC 7230. The request has been rejected.\n\tat org.apache.coyote.http11.Http11InputBuffer.skipLine(Http11InputBuffer.java:1074) ~[tomcat-embed-core-9.0.75.jar:9.0.75]\n\tat org.apache.coyote.http11.Http11InputBuffer.parseHeader(Http11InputBuffer.java:905) ~[tomcat-embed-core-9.0.75.jar:9.0.75]\n\tat org.apache.coyote.http11.Http11InputBuffer.parseHeaders(Http11InputBuffer.java:591) ~[tomcat-embed-core-9.0.75.jar:9.0.75]\n\tat org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:286) ~[tomcat-embed-core-9.0.75.jar:9.0.75]\n\tat org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63) ~[tomcat-embed-core-9.0.75.jar:9.0.75]\n\tat org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:926) ~[tomcat-embed-core-9.0.75.jar:9.0.75]\n\tat org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1791) ~[tomcat-embed-core-9.0.75.jar:9.0.75]\n\tat org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52) ~[tomcat-embed-core-9.0.75.jar:9.0.75]\n\tat org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191) ~[tomcat-embed-core-9.0.75.jar:9.0.75]\n\tat org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659) ~[tomcat-embed-core-9.0.75.jar:9.0.75]\n\tat org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) ~[tomcat-embed-core-9.0.75.jar:9.0.75]\n\tat java.base/java.lang.Thread.run(Thread.java:834) ~[na:na]\n\nexpected: <200 OK> but was: <400 BAD_REQUEST>\nExpected :200 OK\nActual :400 BAD_REQUEST\n\n\norg.opentest4j.AssertionFailedError: expected: <200 OK> but was: <400 BAD_REQUEST>\n\tat app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)\n\tat app//org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)\n\tat app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)\n\tat app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)\n\tat app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141)\n\tat app//com.netflix.spinnaker.kork.tomcat.WebEnvironmentTest.testTomcatWithIllegalHttpHeaders(WebEnvironmentTest.java:59)\n```\nThe root cause of the issue is introduction of new property \"server.tomcat.reject-illegal-header\" in spring boot [2.6.x](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.6-Release-Notes#miscellaneous), which overrides the spinnaker property \"default.rejectIllegalHeader\". Since \"server.tomcat.reject-illegal-header\" property is true by default, the test get failed. In order to honor the spinnaker property \"default.rejectIllegalHeader\", refactored the code to map both the properties.","shortMessageHtmlLink":"chore(dependency): upgrade spring boot from 2.5.15 to 2.6.15 and spri…"}},{"before":"9a9324cbd1a85df92b2571799059a1224aee4dc5","after":"8513635c4b3c6293d00e0f3fbf12dc99539d95b0","ref":"refs/heads/master","pushedAt":"2024-03-11T15:05:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jasonmcintosh","name":"Jason","path":"/jasonmcintosh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1070971?s=80&v=4"},"commit":{"message":"chore(dependencies): use version 2.9.0 of com.jayway.jsonpath:json-path (#1172)\n\nto resolve CVE-2023-51074.\r\n\r\nbefore:\r\n\r\n +--- com.jayway.jsonpath:json-path:2.5.0\r\n | +--- net.minidev:json-smart:2.3 -> 2.4.10\r\n | | \\--- net.minidev:accessors-smart:2.4.9\r\n | | \\--- org.ow2.asm:asm:9.3\r\n | \\--- org.slf4j:slf4j-api:1.7.30 -> 1.7.36\r\n\r\nafter:\r\n\r\n +--- com.jayway.jsonpath:json-path:2.5.0 -> 2.9.0\r\n | +--- net.minidev:json-smart:2.5.0\r\n | | \\--- net.minidev:accessors-smart:2.5.0\r\n | | \\--- org.ow2.asm:asm:9.3\r\n | \\--- org.slf4j:slf4j-api:2.0.11 -> 1.7.36\r\n\r\nCo-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>","shortMessageHtmlLink":"chore(dependencies): use version 2.9.0 of com.jayway.jsonpath:json-pa…"}},{"before":"db7e4be49bb52a42aa54333211945a115fe282e5","after":"9a9324cbd1a85df92b2571799059a1224aee4dc5","ref":"refs/heads/master","pushedAt":"2024-03-11T03:27:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependencies): use version 1.2.13 of logback (#1171)\n\nto resolve CVE-2023-6378 and CVE-2023-6481. See See\nhttps://logback.qos.ch/news.html#1.3.12 and https://logback.qos.ch/news.html#1.2.13.\n\nbefore:\n\n| | | +--- ch.qos.logback:logback-classic:1.2.12\n| | | | +--- ch.qos.logback:logback-core:1.2.12\n| | | | \\--- org.slf4j:slf4j-api:1.7.32 -> 1.7.36\n\nafter:\n\n| | | +--- ch.qos.logback:logback-classic:1.2.12 -> 1.2.13\n| | | | +--- ch.qos.logback:logback-core:1.2.13\n| | | | \\--- org.slf4j:slf4j-api:1.7.32 -> 1.7.36\n\nCo-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>","shortMessageHtmlLink":"chore(dependencies): use version 1.2.13 of logback (#1171)"}},{"before":"f1aa0aaa6d2f29d71f0f33a26da377da9131825a","after":"db7e4be49bb52a42aa54333211945a115fe282e5","ref":"refs/heads/master","pushedAt":"2024-03-11T03:18:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependencies): use version 0.9.4 of org.bitbucket.b_c:jose4j (#1170)\n\nto resolve CVE-2023-51775.\n\nNo change to dependencies in kork. $ ./gradlew clouddriver-kubernetes:dependencies and ./gradlew orca-clouddriver:dependencies change as follows:\n\nbefore:\n\n+--- io.kubernetes:client-java -> 11.0.4\n| \\--- org.bitbucket.b_c:jose4j:0.7.3 -> 0.9.3\n| \\--- org.slf4j:slf4j-api:1.7.21 -> 1.7.32\n\nafter:\n\n+--- io.kubernetes:client-java -> 11.0.4\n| \\--- org.bitbucket.b_c:jose4j:0.7.3 -> 0.9.4\n| \\--- org.slf4j:slf4j-api:1.7.36 -> 1.7.32","shortMessageHtmlLink":"chore(dependencies): use version 0.9.4 of org.bitbucket.b_c:jose4j (#…"}},{"before":"2ae4f0b03062151a35b31c3ef8ab686e03ed83a6","after":"a982ca062a66f31a0549fa1b81bfd55d8e580c5b","ref":"refs/heads/release-1.33.x","pushedAt":"2024-03-07T19:00:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(s3ArtifactStore): Backport of 1164 direct to branch (#1169)","shortMessageHtmlLink":"fix(s3ArtifactStore): Backport of 1164 direct to branch (#1169)"}},{"before":"5b33c24e2513ad9905e71a58c72817f7fea441d5","after":"ecb98c5ffcd38ed6e57c8bb4c9f6a45f0ad9c351","ref":"refs/heads/release-1.32.x","pushedAt":"2024-03-07T19:00:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(s3Artifacts): Fixes where artifacts are SPeL vs. base64 direct - backport of 1164 (#1168)","shortMessageHtmlLink":"fix(s3Artifacts): Fixes where artifacts are SPeL vs. base64 direct - …"}},{"before":"5f4145c13b033b0354c89a26a8aff32b2f500259","after":null,"ref":"refs/heads/mergify/bp/release-1.31.x/pr-1164","pushedAt":"2024-03-07T18:43:11.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":"3f9949a8c44d853086866e937b065365d5da9f20","after":null,"ref":"refs/heads/mergify/bp/release-1.32.x/pr-1164","pushedAt":"2024-03-07T18:43:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":"5c11adfb6f1eb3bff57d587d8415a3e60ff281a9","after":null,"ref":"refs/heads/mergify/bp/release-1.33.x/pr-1164","pushedAt":"2024-03-07T18:43:09.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":null,"after":"5f4145c13b033b0354c89a26a8aff32b2f500259","ref":"refs/heads/mergify/bp/release-1.31.x/pr-1164","pushedAt":"2024-03-06T08:00:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(artifacts): Do not store non-base64 artifacts (#1164)\n\nThis commit addresses a bug where storing SpEL can cause major issues\ndown the chain, e.g. expected artifacts.\n\nThe easiest solution is to simply not store the artifact, but\nimprovements could be made to evaluate the SpEL, if it makes sense to do\n\nSigned-off-by: benjamin-j-powell \nCo-authored-by: benjamin-j-powell \n(cherry picked from commit f1aa0aaa6d2f29d71f0f33a26da377da9131825a)\n\n# Conflicts:\n#\tkork-artifacts/src/main/java/com/netflix/spinnaker/kork/artifacts/artifactstore/s3/S3ArtifactStoreStorer.java\n#\tkork-artifacts/src/test/java/com/netflix/spinnaker/kork/artifacts/artifactstore/s3/S3ArtifactStoreStorerTest.java","shortMessageHtmlLink":"fix(artifacts): Do not store non-base64 artifacts (#1164)"}},{"before":null,"after":"3f9949a8c44d853086866e937b065365d5da9f20","ref":"refs/heads/mergify/bp/release-1.32.x/pr-1164","pushedAt":"2024-03-06T07:59:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(artifacts): Do not store non-base64 artifacts (#1164)\n\nThis commit addresses a bug where storing SpEL can cause major issues\ndown the chain, e.g. expected artifacts.\n\nThe easiest solution is to simply not store the artifact, but\nimprovements could be made to evaluate the SpEL, if it makes sense to do\n\nSigned-off-by: benjamin-j-powell \nCo-authored-by: benjamin-j-powell \n(cherry picked from commit f1aa0aaa6d2f29d71f0f33a26da377da9131825a)\n\n# Conflicts:\n#\tkork-artifacts/src/main/java/com/netflix/spinnaker/kork/artifacts/artifactstore/s3/S3ArtifactStoreStorer.java\n#\tkork-artifacts/src/test/java/com/netflix/spinnaker/kork/artifacts/artifactstore/s3/S3ArtifactStoreStorerTest.java","shortMessageHtmlLink":"fix(artifacts): Do not store non-base64 artifacts (#1164)"}},{"before":null,"after":"5c11adfb6f1eb3bff57d587d8415a3e60ff281a9","ref":"refs/heads/mergify/bp/release-1.33.x/pr-1164","pushedAt":"2024-03-06T07:59:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(artifacts): Do not store non-base64 artifacts (#1164)\n\nThis commit addresses a bug where storing SpEL can cause major issues\ndown the chain, e.g. expected artifacts.\n\nThe easiest solution is to simply not store the artifact, but\nimprovements could be made to evaluate the SpEL, if it makes sense to do\n\nSigned-off-by: benjamin-j-powell \nCo-authored-by: benjamin-j-powell \n(cherry picked from commit f1aa0aaa6d2f29d71f0f33a26da377da9131825a)\n\n# Conflicts:\n#\tkork-artifacts/src/test/java/com/netflix/spinnaker/kork/artifacts/artifactstore/s3/S3ArtifactStoreStorerTest.java","shortMessageHtmlLink":"fix(artifacts): Do not store non-base64 artifacts (#1164)"}},{"before":"93c3fe61731369e355038824a555d814ea3026aa","after":"f1aa0aaa6d2f29d71f0f33a26da377da9131825a","ref":"refs/heads/master","pushedAt":"2024-03-05T23:44:34.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(artifacts): Do not store non-base64 artifacts (#1164)\n\nThis commit addresses a bug where storing SpEL can cause major issues\ndown the chain, e.g. expected artifacts.\n\nThe easiest solution is to simply not store the artifact, but\nimprovements could be made to evaluate the SpEL, if it makes sense to do\n\nSigned-off-by: benjamin-j-powell \nCo-authored-by: benjamin-j-powell ","shortMessageHtmlLink":"fix(artifacts): Do not store non-base64 artifacts (#1164)"}},{"before":"63726175415cff24bf2e7ccaf4dab9ee1d40f4fc","after":"93c3fe61731369e355038824a555d814ea3026aa","ref":"refs/heads/master","pushedAt":"2024-03-04T22:19:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"test(artifacts): extend testing of applicationsRegex (#1162)\n\nto verify exact matches and use of regexes in both the \"allow list\" and \"deny list\" cases.","shortMessageHtmlLink":"test(artifacts): extend testing of applicationsRegex (#1162)"}},{"before":"690ec5d2f93d401b4ce752922eb7557c585ff4a2","after":"63726175415cff24bf2e7ccaf4dab9ee1d40f4fc","ref":"refs/heads/master","pushedAt":"2024-03-03T15:39:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"perf(artifacts): compile appliationsRegex once instead of on each use (#1161)\n\n* refactor(artifacts/test): remove cast when mocking headObject call\n\n* test(artifacts): demonstrate behavior of applicationsRegex\n\n* perf(artifacts): compile appliationsRegex once instead of on each use","shortMessageHtmlLink":"perf(artifacts): compile appliationsRegex once instead of on each use ("}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAERs9SQAA","startCursor":null,"endCursor":null}},"title":"Activity · spinnaker/kork"}