-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clouddriver 5.83.0 is unable to execute certain changesets against PostgreSQL #6942
Comments
@Badbond - It seems to be the case that these two files missed the correction. I will work the fix. |
clouddriver 5.83.0 was first present in spinnaker 1.33, so backporting the fix to both the 1.33 and 1.34 branches. |
I can confirm that 1.33.2 fixed the issue modulo the changeset issues documented in #6941. @kirangodishala can we close the ticket or do you wish to keep it open until #6941 has been resolved too? |
Closing the issue as it's already fixed. |
Issue Summary:
Deploying Clouddriver 5.83.0 with a fresh PostgreSQL database fails due disallowed field usage for PostgreSQL in Liquibase changesets.
Cloud Provider(s):
Local (but generic, so should affect all environments).
Environment:
Clouddriver (5.83.0 and 5.84.0) with a clean PostgreSQL 16.2 database.
Orca (8.48.0) seems to start fine with a PostgreSQL database.
We are not (yet) running other Spinnaker services with PostgreSQL storages.
Feature Area:
PostgreSQL persistence for Clouddriver.
Description:
We have a testing setup for various internal plugins, where we attach the plugins in the Docker containers for various Spinnaker services. We noticed that as of Clouddriver 5.83.0 (5.82.2 was still fine), we are unable to run this test setup (which always starts with a clean state), as it can not execute all Liquibase changesets against our PostgreSQL 16.2 database.
It seems that as of Clouddriver 5.83.0 matches matches the timing of the Liquibase upgrade from 3.10.3 to 4.24.0: see spinnaker/kork#1117. As mentioned in the aforelinked pull request, for Orca some changes were made to make the changesets compatible with PostgreSQL by omitting
afterColumn
fields. It seems from the logs that this was not applied to Clouddriver's changesets.Steps to Reproduce:
With the following Clouddriver SQL and Redis configuration:
By running Clouddriver 5.83.0 against a clean database, the instance fails to start due to disallowed fields in the changesets.
Additional Details:
Clouddriver 5.83.0 logs
The text was updated successfully, but these errors were encountered: