Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle environment variables better #855

Open
almet opened this issue Oct 13, 2021 · 3 comments
Open

Handle environment variables better #855

almet opened this issue Oct 13, 2021 · 3 comments

Comments

@almet
Copy link
Member

almet commented Oct 13, 2021

@zorun said in another discussion :

I think variables are getting out of control: we already had 4 places where we define them, and that's now 5!

@almet
Copy link
Member Author

almet commented Oct 13, 2021

I think we should find a better way to handle this. We currently have these places where we define variables :

Yeah. I think we could do a better job here :-D

@zorun
Copy link
Collaborator

zorun commented Jul 30, 2023

I just found out we have another place with variables: https://hub.docker.com/r/ihatemoney/ihatemoney

It doesn't seem to come from our repo, and it's outdated (the format of MAIL_DEFAULT_SENDER has changed to be a single string)

@almet
Copy link
Member Author

almet commented Apr 28, 2024

We would like to have a unique place where all variables are defined, in a formal way: name, type, doc, default value. We would include settings from ihatemoney and Flask ones, SQLAlchemy, etc.

Then, we would use this unique source of configuration variables to generate the rest. For docker, we could replace the shell entrypoint with a python entrypoint to ease the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants