Annotations on generic or array incorrectly considered fix #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NonNull annotations might be on the return type or on the parameters but they might also be on generics of the corresponding types. When they are on the return/parameter we should consider them, when they are on the generics we (currently) should ignore them.
The typePath seem to be set when the annotation is for a generic
This was referenced Aug 5, 2023
Closed
This was referenced Aug 5, 2023
gtoison
changed the title
ThrawnCA
approved these changes
Aug 7, 2023
|
Looks good, the bug is fixed with this PR. Thank you! |
JuditKnoll
requested changes
Aug 9, 2023
...gs-tests/src/test/java/edu/umd/cs/findbugs/nullness/TestCheckerFrameworkTypeAnnotations.java
Outdated
Show resolved
Hide resolved
...gs-tests/src/test/java/edu/umd/cs/findbugs/nullness/TestCheckerFrameworkTypeAnnotations.java
Outdated
Show resolved
Hide resolved
JuditKnoll
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NonNull annotations might be on the return type or on the parameters but it might also be on generics of the corresponding types. When they are on the return/parameter we should consider them, when they are on the generics we (currently) should ignore them.
For instance
List<@NonNull V>means that the list contains non null elements, but the list itself might be nullSee #2500