Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT_CONSTRUCTOR_THROW: ignores empty final finalize() on base types #2665

Closed
big-andy-coates opened this issue Oct 26, 2023 · 0 comments · Fixed by #2666
Closed

CT_CONSTRUCTOR_THROW: ignores empty final finalize() on base types #2665

big-andy-coates opened this issue Oct 26, 2023 · 0 comments · Fixed by #2666

Comments

@big-andy-coates
Copy link
Contributor

Issue #2642 confirmed that adding an empty final finailize() method mitigated any CT_CONSTRUCTOR_THROW issue.

  @Override
  @SuppressWarnings({ "deprecation", "Finalize" })
  protected final void finalize() {}

However, spotbugs does not detect the empty final finalize() if it is defined by a base type, e.g.

public class BaseType {
  @Override
  @SuppressWarnings({ "deprecation", "Finalize" })
  protected final void finalize() {}
}

public class SubType extends BaseType {
   public SubType(boolean fail) {
      if (fail) throw new RuntimeException();
   }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant