Replies: 1 comment
-
Hey Maskowh, thank you for the perfect summary! ✨ Indeed they seem to have made some changes to the api again and I can't find any update blog post on that. I think your proposal to deprecate the current implementation and add the new is a great way to go 👍 You can go ahead and add this in a PR :) |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello,
I think the documentation for Check if Users Follow Playlist changed, and this lib still use the old format in CheckUsersFollowPlaylistRequest.java
What seems to have changed:
The endpoint used in lib is
/v1/users/{owner_id}/playlists/{playlist_id}/followers/contains
The endpoint in the docutmentation is
/v1/playlists/{playlist_id}/followers/contains
They seem to have removed the
owner_id
param and no longer mention it in the documentation.The requests I do with this lib still works, meaning the old endpoint with the
owner_id
param is currently still supported, but it might not be the case in the future.If you agree this is an issue, I can do a branch to fix, since the fix seems to be easy: I think changing the endpoint path, removing the owner_id builder method and removing the
owner_id
param in the SpotifyApi method should be enough.But I could also try to not introduce breaking changes by only deprecating the owner_id builder method instead of removing it for now, and deprecating the method using the
owner_id
param in the SpotifyApi method, while adding the same method without theowner_id
param.It would need to update the example and the test too.
Thanks for the work on this wrapper and for keeping it uptodate.
Beta Was this translation helpful? Give feedback.
All reactions