Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Special characters in filenames are not escaped #247

Open
nudgegoonies opened this issue Jul 7, 2016 · 3 comments
Open

Special characters in filenames are not escaped #247

nudgegoonies opened this issue Jul 7, 2016 · 3 comments
Labels
bug help wanted pinned exempted from stalebot

Comments

@nudgegoonies
Copy link
Contributor

Description

I have a Spring Project which produces files with a $ character in the middle of one filename. The $ sign is not escaped in the dockerfile and docker build tries variable substitution and cannot find the file.

How to reproduce

I have this file:

ServletInitializer$ApplicationContextHolder.class

What do you expect

$ character is escaped and file is copied to the image.

What happened instead

The $ character is not escaped in the dockerfile produced by the docker-maven-plugin. Docker cannot find the file because characters after the $ are interpreted as variable. In my case, the variable $ApplicationContextHolder does not exists and docker only looks for ServletInitializer.class

Software:

  • docker version: 1.11.2
  • docker-maven-plugin version: 0.4.10
  • maven version: 3.3.9

Link to documentation where escaping is explained:

https://docs.docker.com/engine/reference/builder/

@stale
Copy link

stale bot commented Sep 11, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 11, 2018
@davidxia davidxia added the pinned exempted from stalebot label Sep 11, 2018
@stale stale bot removed the stale label Sep 11, 2018
@Abhishek1121-tech
Copy link

Any update on this ?

@nudgegoonies
Copy link
Contributor Author

At least for us this was fixed here: #248

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug help wanted pinned exempted from stalebot
Projects
None yet
Development

No branches or pull requests

3 participants