Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new @babel/typescript preset instead of ts-loader #63

Closed
tniezg opened this issue Mar 19, 2019 · 2 comments
Closed

Use new @babel/typescript preset instead of ts-loader #63

tniezg opened this issue Mar 19, 2019 · 2 comments
Assignees

Comments

@tniezg
Copy link
Contributor

tniezg commented Mar 19, 2019

Is your feature request related to a problem? Please describe.

Describe the solution you'd like.

Use similar approach as in https://github.com/facebook/create-react-app with @babel/typescript and https://github.com/Realytics/fork-ts-checker-webpack-plugin

Describe alternatives you've considered.

  • Add extra import statements inside files.
  • Modify tsconfig.json and ts-loader configs to have babel-loader recognize missing .ts files.

Additional context

-

@tniezg tniezg self-assigned this Mar 19, 2019
@tniezg
Copy link
Contributor Author

tniezg commented Mar 19, 2019

Another thread about the issue with regenerating pure TS files: TypeStrong/fork-ts-checker-webpack-plugin#36. Bottom line - there's no solution as of now.

Closing issue. Will reopen when there are more reasons to upgrade.

For future reference: #64

Using a CI service will partially help with this issue. CI builds will fail when pure TS files are "incorrect".

@tniezg
Copy link
Contributor Author

tniezg commented Apr 7, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant