Migrate *-agent samples to Native Build Tools agent support

[sbrannen]

The commandlinerunner-agent sample currently does not work.

At this point we should remove the following...

https://github.com/spring-projects-experimental/spring-native/blob/77be942e39c6c441beb65293d94e9e80de7ccd69/samples/commandlinerunner-agent/pom.xml#L47-L63

and

https://github.com/spring-projects-experimental/spring-native/blob/77be942e39c6c441beb65293d94e9e80de7ccd69/samples/commandlinerunner-agent/pom.xml#L80

... and switch to using the built-in support for running with the GraalVM agent using Native Build Tools.

[sbrannen]

Blocked by:

• Support configuration of agent options when using the agent graalvm/native-build-tools#162

[sdeleuze]

I am not sure to understand why native-agent mode configuration has been removed, could you please share more about that?

[sbrannen]

I am not sure to understand why native-agent mode configuration has been removed, could you please share more about that?

Good catch!

That was an experiment that I forgot to undo before committing.

I'll add it back.

[sdeleuze]

So far it seems we are blocked by an issue on GraalVM 21.3.

When executing the agent on tests, it generates this kind of entry that make native tests fail:

[
  {
    "name":"org.springframework.boot.availability.ApplicationAvailabilityBean",
    "allDeclaredFields":true,
    "queryAllPublicMethods":true
  }
]

With this error:

java.lang.ClassCastException: sun.reflect.generics.tree.FieldTypeSignature[] cannot be cast to java.lang.reflect.Type[]
       sun.reflect.generics.reflectiveObjects.TypeVariableImpl.getBounds(TypeVariableImpl.java:87)
       com.sun.beans.TypeResolver.erase(TypeResolver.java:242)
       com.sun.beans.TypeResolver.erase(TypeResolver.java:274)
       java.beans.FeatureDescriptor.getParameterTypes(FeatureDescriptor.java:391)
       java.beans.MethodDescriptor.setMethod(MethodDescriptor.java:118)

This error happen when executing native test, native compilation of the app is fine.

Also when using queryAllPublicMethods instead of allPublicMethods, it works as expected:

[
  {
    "name":"org.springframework.boot.availability.ApplicationAvailabilityBean",
    "allDeclaredFields":true,
    "allPublicMethods":true
  }
]

We need to bring that to GraalVM team attention. I think that mean we need to move agent support to at least 0.11.1.

[sdeleuze]

Will require NBT 0.9.9 due to graalvm/native-build-tools#179.

[sdeleuze]

Blocked by 2 additional issues with NBT 0.9.10, see sdeleuze@test-agent.

[sdeleuze]

I created graalvm/native-build-tools#207 and graalvm/native-build-tools#208 related issues.

[sdeleuze]

Depends on #1638.

[sdeleuze]

Works with NBT 0.9.12-SNAPSHOT, mvn -Pnative -DskipNativeTests package and the following configuration:

<build>
		<plugins>
			<plugin>
				<groupId>org.apache.maven.plugins</groupId>
				<artifactId>maven-antrun-plugin</artifactId>
				<executions>
					<execution>
						<id>copy-agent-config</id>
						<phase>prepare-package</phase>
						<goals>
							<goal>run</goal>
						</goals>
						<configuration>
							<target>
								<mkdir dir="${project.build.directory}/native/agent-output/main"/>
								<copy todir="${project.build.directory}/native/agent-output/main">
									<fileset dir="${project.build.directory}/native/agent-output/test" />
								</copy>
							</target>
						</configuration>
					</execution>
				</executions>
			</plugin>
			<plugin>
				<groupId>org.springframework.experimental</groupId>
				<artifactId>spring-aot-maven-plugin</artifactId>
				<configuration>
					<mode>native-agent</mode>
					<removeSpelSupport>true</removeSpelSupport>
				</configuration>
			</plugin>
			<plugin>
				<groupId>org.springframework.boot</groupId>
				<artifactId>spring-boot-maven-plugin</artifactId>
			</plugin>
			<plugin>
				<groupId>org.graalvm.buildtools</groupId>
				<artifactId>native-maven-plugin</artifactId>
				<extensions>true</extensions>
				<configuration>
					<agent>
						<enabled>true</enabled>
						<options name="test">
							<option>access-filter-file=${basedir}/access-filter.json</option>
						</options>
					</agent>
				</configuration>
			</plugin>
		</plugins>
	</build>

I will update the agent samples once NBT 0.9.12 has been released.