Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are there any plans to support http/2.0 #809

Open
thousmile opened this issue Dec 20, 2022 · 6 comments
Open

Are there any plans to support http/2.0 #809

thousmile opened this issue Dec 20, 2022 · 6 comments
Assignees
@galaxy-sea
Labels
enhancement New feature or request

Comments

@thousmile
Copy link

http server enable http2.0 .
But feign client still uses http/1.1 protocol
@galaxy-sea
Copy link
Contributor

hello @OlgaMaciaszek , can you assign this issue to me.

@OlgaMaciaszek
Copy link
Collaborator

Sure @galaxy-sea :) .

@OlgaMaciaszek OlgaMaciaszek added enhancement New feature or request and removed waiting-for-triage labels Jan 17, 2023
@OlgaMaciaszek OlgaMaciaszek linked a pull request Jan 31, 2023 that will close this issue
okhttp supports custom protocols. gh-809 #820
Closed
@OlgaMaciaszek
Copy link
Collaborator

HTTP2 is supported by OkHttp and it's enabled by default. There's also support in Apache HC5. We should add the support for this within this issue.

@galaxy-sea
Copy link
Contributor

galaxy-sea commented Feb 2, 2023 •
edited

hello @OlgaMaciaszek , feign.hc5.ApacheHttp5Client does not support the http2, but feign.hc5.AsyncApacheHttp5Client supports http2

@galaxy-sea
Copy link
Contributor

I've sorted out the clients that support the http2 protocol. AsyncClients is the best for supporting the http2 protocol.

client http/2.0
feign.Client.Default no
feign.hc5.ApacheHttp5Client no
feign.okhttp.OkHttpClient yes
feign.http2client.Http2Client yes
AsyncClient http/2.0
feign.AsyncClient.Default yes
feign.hc5.AsyncApacheHttp5Client yes
ffeign.okhttp.OkHttpClient yes
feign.http2client.Http2Client yes

@galaxy-sea
Copy link
Contributor

Maybe we need to implement the http2 protocol on the basis of Async feign flow #511.

@OlgaMaciaszek OlgaMaciaszek mentioned this issue Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galaxy-sea galaxy-sea

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

okhttp supports custom protocols. gh-809 galaxy-sea/spring-cloud-openfeign
4 participants
@OlgaMaciaszek @thousmile @galaxy-sea @spring-cloud-issues