Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Cloud Commons Bootstrap is not enabled by default for Spring-Cloud-2022.0 #273

Open
fdurantsq opened this issue Oct 9, 2023 · 2 comments

Comments

@fdurantsq
Copy link

Describe the bug
Really I'm just suggesting changes to breaking changes list, and to add spring-cloud-bootstrap-starter to spring-cloud-commons documentation so people can more easily make upgrades or get started with using Bootstrap configurations. Specifically:

spring.config.use-legacy-processing=true no longer enables bootstrap because of changes in Spring Boot 3.0. Please use spring.cloud.bootstrap.enabled=true.

Does not adequately describe the side-effects of the changeset here

Source: https://github.com/spring-cloud/spring-cloud-release/wiki/Spring-Cloud-2022.0-Release-Notes

Steps to reproduce:

  • Use a spring cloud project prior to 2022, using a spring.factories class pointing to BootstrapConfiguration files. Do not use spring-cloud-starter-bootstrap
  • Upgrade to 2022, following the migration guide

Expectations:

  • Breaking changes list above describes that "spring.cloud.bootstrap.enabled does not default to true anymore." Users must.... [see Actual Behavior]"
  • Add section that "spring-cloud-starter-bootstrap" will auto enabled bootstrap?

Actual behavior:

  • BootstrapConfiguration does not load, until a system property is set as described above, or spring-cloud-bootstrap-starter is added which adds the Marker.java class that enabled BootstrapConfiguration initialization again.
@spencergibb
Copy link
Member

I disagree. Both methods should work. If the property does not work it is a bug. How are you setting the property?

@spencergibb
Copy link
Member

I didn't fully read the last comment. It has to be a system property, environment variable or cli argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants