Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make invalid Java selections impossible in the web UI #1041

Closed
michael-simons opened this issue Nov 26, 2022 · 6 comments
Closed

Make invalid Java selections impossible in the web UI #1041

michael-simons opened this issue Nov 26, 2022 · 6 comments

Comments

@michael-simons
Copy link

The site lets you select Spring Boot 3 + JDK 11 or 8. The generate (Maven) project will still have JDK 17 defined in it. Not a big, but UX can be improved to disable invalid combinations.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 26, 2022
@wilkinsona
Copy link
Contributor

Thanks for the suggestion. Unfortunately, with all of the different clients (web UI, CLI, IDE plugins) it isn't possible to disable invalid combinations consistently. For now, we've settled on adding a note to the generated HELP.md that explains what has happened. #250 is tracking further improvements in this area.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2022
@wilkinsona wilkinsona added status: duplicate and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 28, 2022
@michael-simons
Copy link
Author

Kinda odd that this works though
image
But I see, I am not the only person who stumbled upon this 🤷

@wilkinsona
Copy link
Contributor

wilkinsona commented Nov 28, 2022

Yeah, it is odd. There are some implementation details of how the service is implemented and describes it capabilities leaking out and that's unfortunate. The reason it works for dependencies is that the metadata allows a dependency to describe the versions of Spring Boot with which it is compatible. There's nothing similar for Java versions unfortunately but it would definitely be a nice thing to have. We'll have to see where #250 and our limited bandwidth takes us.

@michael-simons
Copy link
Author

Thanks for the explanation, appreciated.

@lohitharg16
Copy link

how to resolve the build issue as i am default getting 17 and
java: error: release version 17 not supported

Module demo SDK 11 is not compatible with the source version 17.

Upgrade Module SDK in project settings to 17 or higher. Open project settings.

@jeremy-brooks
Copy link

jeremy-brooks commented Mar 13, 2023

how to resolve the build issue as i am default getting 17 and java: error: release version 17 not supported

Module demo SDK 11 is not compatible with the source version 17.

Upgrade Module SDK in project settings to 17 or higher. Open project settings.

@lohitharg16 I also encountered this and from reading the above comments, this is a limitation with the version of the UI where it cannot easily identify if the version of Java is compatible with the version of the spring framework version.

Below taken from : https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-Versions#jdk-version-range

6.0.x is the main production line as of November 2022. This new generation of the framework comes with a JDK 17 and Jakarta EE 9 baseline.
5.3.x is the final feature branch of the 5th generation, with long-term support provided on JDK 8, JDK 11, JDK 17 and the Java EE 8 level.

You will see a note at the very top of your generated HELP.md file in the root of your project saying as much.

Looks like you can regenerate using version 2.x.x of Spring Boot and it works ok. Also the dependencies will be greyed out if they are not supported on the older version, which is helpful.

It would be good to have a note though on the UI to indicate version 3.x.x requires Java 17 and above when you select anything lower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants