Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneccessary Modulith dependencies defined when using database access starters #1400

Open
Arondc opened this issue Feb 3, 2024 · 2 comments
Labels
status: waiting-for-triage An issue we've not yet triaged

Comments

@Arondc
Copy link

Arondc commented Feb 3, 2024

If a project uses a database related starter (e.g. spring-boot-starter-data-jpa, spring-boot-starter-data-jdbc, ...) and also modulith is configured during project setup there are two modulith dependencies in the resulting pom/gradle file.

  1. spring-modulith-starter-core
  2. spring-modulith-starter-jpa / spring-modulith-starter-jdbc /...

The 2nd one always seems to contain the 1st one as a transient dependency, so it could be ommited during project setup.

This has no bigger impact on the project setup (nothing breaks as far as I see it) it just feels a bit strange.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 3, 2024
@Arondc Arondc closed this as completed Feb 3, 2024
@Arondc Arondc reopened this Feb 3, 2024
@odrotbohm
Copy link
Contributor

I'll have a look.

@wilkinsona wilkinsona transferred this issue from spring-io/initializr Feb 4, 2024
@mhalbritter
Copy link
Contributor

Any news on this, @odrotbohm ? Should I take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

No branches or pull requests

4 participants