Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize GitHub language detection #5

Open
arey opened this issue Dec 1, 2017 · 5 comments
Open

Customize GitHub language detection #5

arey opened this issue Dec 1, 2017 · 5 comments
Assignees

Comments

@arey
Copy link
Member

arey commented Dec 1, 2017

GitHub uses linguist to detect languages. For spring-petclinic-reactks, CSS is the first one. It should be Java or TypeScript.
We could customize this behavior, See https://github.com/spring-petclinic/spring-petclinic-kotlin/blob/master/.gitattributes

@ankurshukla10
Copy link

@arey I can send in a pull request for this change, seems pretty straightforward. Anything specific I should take care of? Thanks !!

@arey
Copy link
Member Author

arey commented Dec 9, 2020

Hi @ankurshukla10 , sure, you could submit a change. If you want to upgrade this sample to more recent versions of Spring Boot and ReactJS, you're welcome.

image

@arey
Copy link
Member Author

arey commented Dec 10, 2020

After your PR merge, the languages repartition didn't changed and I don't know why :-(

@ankurshukla10
Copy link

@arey yeah, I noticed too :(. I am trying to check this locally by installing github-linguist on my development machine, but to my bad luck the install keeps on failing. Right now I am getting the attached error. Do you have any insights on why that might be? Or If you can point me in a better direction, that'll be helpful.

Machine-Processor: Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, 2112 Mhz, 4 Core(s), 8 Logical Processor(s)
OS Name: Microsoft Windows 10 Pro (Version-10.0.19041 Build 19041)
Ruby Version: ruby 2.6.5p114 (2019-10-01 revision 67812) [x64-mingw32]
Gem Version: 3.0.3

github-linguist-install-fails.txt

@arey
Copy link
Member Author

arey commented Dec 12, 2020

Maybe you have to install a ruby gem?

gem install ffi -- --enable-system-libffi        # to install the gem manually
bundle config build.ffi --enable-system-libffi   # for bundle install

See https://github.com/ffi/ffi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants