Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 9 modules : split package org.springframework.boot.context.properties #256

Open
pull-vert opened this issue Nov 13, 2019 · 1 comment
Assignees
Labels
status: blocked An issue that's blocked on an external project change type: enhancement A general enhancement

Comments

@pull-vert
Copy link
Contributor

pull-vert commented Nov 13, 2019

This leads to this error when module-info.java requires spring.boot and spring.fu.kofu (that includes module spring.fu.autoconfigure.adapter) :

java.lang.module.ResolutionException: Modules spring.boot and 
spring.fu.autoconfigure.adapter
export package org.springframework.boot.context.properties

Solution is to change this package in project spring-fu-autoconfigure-adapter.

Edit : Even if the goal is to have these new classes included in spring.boot module, it should use a different package as long as it is provided as an external incubating module to allow jigsaw module to work.

@sdeleuze
Copy link
Collaborator

Yeah I have to do that in order to be able to access package private Spring Boo classes, but let's put that in 0.4 bucket in order to work with Spring Boot team to avoid that.

@sdeleuze sdeleuze self-assigned this May 28, 2020
@sdeleuze sdeleuze added this to the 0.4.0 milestone May 28, 2020
@sdeleuze sdeleuze modified the milestones: 0.4.0, 0.5.0 Jul 22, 2020
@sdeleuze sdeleuze modified the milestones: 0.5.0, 0.4.1, 0.4.2 Sep 22, 2020
@sdeleuze sdeleuze modified the milestones: 0.4.2, 0.6.0 Oct 31, 2020
@sdeleuze sdeleuze added type: enhancement A general enhancement status: blocked An issue that's blocked on an external project change labels Jan 8, 2021
@sdeleuze sdeleuze modified the milestones: 0.6.0, General backlog Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked An issue that's blocked on an external project change type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants