Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and fix how bean naming/override works #359

Open
sdeleuze opened this issue Jan 27, 2021 · 0 comments
Open

Clarify and fix how bean naming/override works #359

sdeleuze opened this issue Jan 27, 2021 · 0 comments
Assignees
Labels
type: enhancement A general enhancement

Comments

@sdeleuze
Copy link
Collaborator

Currently in a few places we are invoking BeanDefinitionReaderUtils.uniqueBeanName() "manually" to generate a unique bean name in order to have multiple beans (see for example for having multiple routers here).

It would be nice to be analyze more closely what Spring Boot does

  • Spring Boot by default prevents bean overriding (can be changed via spring.main.allow-bean-definition-overriding=true), we should probably do that as well to avoid silent issues.
  • Maybe some differences come from the fact that we are not using the annotation infrastucture (for example AnnotationBeanNameGenerator or FullyQualifiedAnnotationBeanNameGenerator)
  • There may be inconsistencies between Boot autoconfiguration but let's do our best for now by updating autoconfigure-adapter if needed, this will be fixed in a more structural way via Generate automatically functional configuration from Spring Boot #273.
@sdeleuze sdeleuze added the type: enhancement A general enhancement label Jan 27, 2021
@sdeleuze sdeleuze added this to the 0.5.0 milestone Jan 27, 2021
@sdeleuze sdeleuze self-assigned this Jan 27, 2021
@sdeleuze sdeleuze modified the milestones: 0.5.1, 0.6.0, General backlog Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant