Skip to content

Commit 822593b

Browse files
garyrussellartembilan
authored andcommittedDec 21, 2017
Fix JUnit dependencies
- eliminate the `platform-commons` dependency - make the `jupiter-api` dependency optional
1 parent d73f4ff commit 822593b

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed
 

‎build.gradle

+1-3
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ subprojects { subproject ->
130130

131131
testCompile "org.junit.jupiter:junit-jupiter-api:${junitJupiterVersion}"
132132
testRuntime "org.junit.jupiter:junit-jupiter-engine:${junitJupiterVersion}"
133-
testRuntime "org.junit.platform:junit-platform-commons:${junitPlatformVersion}"
134133
testRuntime "org.junit.platform:junit-platform-launcher:${junitPlatformVersion}"
135134

136135
// To support JUnit 4 tests
@@ -287,8 +286,7 @@ project('spring-rabbit-junit') {
287286
exclude group: 'org.springframework', module: 'spring-web'
288287
}
289288
compile "org.springframework:spring-web:$springVersion"
290-
compile "org.junit.jupiter:junit-jupiter-api:${junitJupiterVersion}"
291-
compile "org.junit.platform:junit-platform-commons:${junitPlatformVersion}"
289+
compile ("org.junit.jupiter:junit-jupiter-api:${junitJupiterVersion}", optional)
292290
compileOnly 'org.apiguardian:apiguardian-api:1.0.0'
293291

294292
}

‎spring-rabbit-junit/src/main/java/org/springframework/amqp/rabbit/junit/LongRunningIntegrationTestCondition.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
import org.junit.jupiter.api.extension.ConditionEvaluationResult;
2323
import org.junit.jupiter.api.extension.ExecutionCondition;
2424
import org.junit.jupiter.api.extension.ExtensionContext;
25-
import org.junit.platform.commons.util.AnnotationUtils;
2625

26+
import org.springframework.core.annotation.AnnotationUtils;
2727
import org.springframework.util.StringUtils;
2828

2929
/**
@@ -42,9 +42,9 @@ public class LongRunningIntegrationTestCondition implements ExecutionCondition {
4242
@Override
4343
public ConditionEvaluationResult evaluateExecutionCondition(ExtensionContext context) {
4444
Optional<AnnotatedElement> element = context.getElement();
45-
Optional<LongRunning> longRunning = AnnotationUtils.findAnnotation(element, LongRunning.class);
46-
if (longRunning.isPresent()) {
47-
String property = longRunning.get().value();
45+
LongRunning longRunning = AnnotationUtils.findAnnotation(element.get(), LongRunning.class);
46+
if (longRunning != null) {
47+
String property = longRunning.value();
4848
if (!StringUtils.hasText(property)) {
4949
property = LongRunningIntegrationTest.RUN_LONG_INTEGRATION_TESTS;
5050
}

‎spring-rabbit-junit/src/main/java/org/springframework/amqp/rabbit/junit/RabbitAvailableCondition.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
import org.junit.jupiter.api.extension.ParameterContext;
2929
import org.junit.jupiter.api.extension.ParameterResolutionException;
3030
import org.junit.jupiter.api.extension.ParameterResolver;
31-
import org.junit.platform.commons.util.AnnotationUtils;
3231

32+
import org.springframework.core.annotation.AnnotationUtils;
3333
import org.springframework.util.Assert;
3434

3535
import com.rabbitmq.client.ConnectionFactory;
@@ -53,13 +53,13 @@ public class RabbitAvailableCondition implements ExecutionCondition, AfterAllCal
5353
@Override
5454
public ConditionEvaluationResult evaluateExecutionCondition(ExtensionContext context) {
5555
Optional<AnnotatedElement> element = context.getElement();
56-
Optional<RabbitAvailable> rabbit = AnnotationUtils.findAnnotation(element, RabbitAvailable.class);
57-
if (rabbit.isPresent()) {
56+
RabbitAvailable rabbit = AnnotationUtils.findAnnotation(element.get(), RabbitAvailable.class);
57+
if (rabbit != null) {
5858
try {
59-
String[] queues = rabbit.get().queues();
59+
String[] queues = rabbit.queues();
6060
BrokerRunning brokerRunning = getStore(context).get("brokerRunning", BrokerRunning.class);
6161
if (brokerRunning == null) {
62-
if (rabbit.get().management()) {
62+
if (rabbit.management()) {
6363
brokerRunning = BrokerRunning.isBrokerAndManagementRunningWithEmptyQueues(queues);
6464
}
6565
else {

0 commit comments

Comments
 (0)
Please sign in to comment.