Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated method in the RabbitListenerErrorHandler #2654

Open
artembilan opened this issue Mar 13, 2024 · 0 comments
Open

Remove deprecated method in the RabbitListenerErrorHandler #2654

artembilan opened this issue Mar 13, 2024 · 0 comments
Labels
in: rabbitmq type: enhancement
Milestone
3.2.0-M1

Comments

@artembilan
Copy link
Member

Related issue: #2652

Also see TODO in the MessagingMessageListenerAdapter where we won't need to sent that AmqpHeaders.CHANNEL any more.
@artembilan artembilan added this to the 3.2.0-M1 milestone Mar 13, 2024
artembilan added a commit that referenced this issue Mar 13, 2024
@artembilan
GH-2652: Make RabbitListenerErrorHandler aware of Channel
0049ce7 
Fixes: #2652

Whenever a `MessageConversionException` occurs,
the raw Spring message returned in `RabbitListenerErrorHandler#handleError` is null.
Channel information is being stored inside of that raw message,
therefore it is not possible to manually nack just failed message

* Introduce a new `handleError(Message, Channel, Message<?>, ListenerExecutionFailedException)`
contract to make a `Channel` access independent of the `Message<?>` result
* Deprecate existing method with the plan to remove in the next version (see #2654)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: rabbitmq type: enhancement
Projects
None yet
Milestone
3.2.0-M1
Development

No branches or pull requests
1 participant
@artembilan