Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename schema-oracle10g to schema-oracle #1057

Closed
spring-projects-issues opened this issue Oct 10, 2016 · 3 comments
Closed

Rename schema-oracle10g to schema-oracle #1057

spring-projects-issues opened this issue Oct 10, 2016 · 3 comments
Labels
in: infrastructure related-to: ddl-scripts type: enhancement
Milestone
5.0.0-M2

Comments

@spring-projects-issues
Copy link
Collaborator

Stéphane Nicoll opened BATCH-2545 and commented

I am not sure I understand the reason why the Oracle script is named oracle10g rather than oracle but this leads to some duplicated logic where we have to guess the platform based on the databaseProductName returned by the datasource meta-data.

If we could have oracle as in Spring Session, that would allows us to remove that unnecessary logic.

Affects: 3.0.7
@spring-projects-issues
Copy link
Collaborator Author

Dave Syer commented

It's been like that in Spring Batch since the beginning (i.e. 2007), when 10g was actually new. I don't know if it's a great idea to change it now. Maybe we could add a copy with a different name?

@spring-projects-issues
Copy link
Collaborator Author

Stéphane Nicoll commented

I know it's been like that for a long time. My point is that it's not really relevant anymore. And the duplication logic outside of batch is pretty bad.

@fmbenhassine fmbenhassine added related-to: ddl-scripts and removed status: waiting-for-triage Issues that we did not analyse yet labels Jan 26, 2021
@fmbenhassine fmbenhassine added this to the 5.0.0 milestone Jan 26, 2021
@fmbenhassine fmbenhassine changed the title Rename schema-oracle10g to schema-oracle [BATCH-2545] Rename schema-oracle10g to schema-oracle Mar 22, 2022
fmbenhassine added a commit that referenced this issue Mar 22, 2022
@fmbenhassine
Rename schema-oracle10g.sql to schema-oracle.sql
984570a 
Resolves ##1057
@fmbenhassine fmbenhassine modified the milestones: 5.0.0, 5.0.0-M2 Mar 22, 2022
@fmbenhassine
Copy link
Contributor

Resolved in 984570a

@wilkinsona wilkinsona mentioned this issue Apr 6, 2022
Closed
lcmarvin pushed a commit to lcmarvin/spring-batch that referenced this issue Apr 16, 2022
@fmbenhassine @lcmarvin
Rename schema-oracle10g.sql to schema-oracle.sql
5c645c2 
Resolves #spring-projects#1057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: infrastructure related-to: ddl-scripts type: enhancement
Projects
None yet
Milestone
5.0.0-M2
Development

No branches or pull requests
2 participants
@fmbenhassine @spring-projects-issues