Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept and return java.time parameters? #3723

Closed
PascalSchumacher opened this issue May 31, 2020 · 4 comments
Closed

Accept and return java.time parameters? #3723

PascalSchumacher opened this issue May 31, 2020 · 4 comments
Labels
status: duplicate Issues that are duplicates of other issues

Comments

@PascalSchumacher
Copy link
Contributor

Currently classes like JobParameters and JobExecution only accept and return java.util.Date.

As java.util.Date has a lot of design flaws and should be avoided, what about adding methods accepting and returning a java.time class like LocalDateTime?

@PascalSchumacher PascalSchumacher added the status: waiting-for-triage Issues that we did not analyse yet label May 31, 2020
@fmbenhassine
Copy link
Contributor

@PascalSchumacher I believe this is a duplicate of #1035 . Do you agree?

@PascalSchumacher
Copy link
Contributor Author

It has a wider scope than #1035, but I fine with closing this issue in favor of #1035. I did not find that issue before creating this one, sorry.

@fmbenhassine
Copy link
Contributor

ok no worries. If it has a wider scope, please edit the title/description of this issue and narrow it to exclude what's already requested in #1035. Thank you upfront.

@mminella
Copy link
Member

For JobParameters, as @benas mentions, we already have an issue open for it. For JobExecution and StepExecution given that the vast majority of users do not manipulate these date other than formatting it, the cost of changing it outweighs the benefit for the few that would benefit from a more rich API. That coupled with the fact that java.util.Date has not been depricated by the JDK makes me think that we should not make this change.

Closing as a duplicate of #1035 where we can discuss the JobParameters use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate Issues that are duplicates of other issues
Projects
None yet
Development

No branches or pull requests

3 participants