FlatFileItemWriter now uses charset to determine default encoding #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmbenhassine
reviewed
Sep 3, 2021
| */ | ||
| public class FlatFileItemWriter<T> extends AbstractFileItemWriter<T> { | ||
|
|
||
| protected LineAggregator<T> lineAggregator; | ||
|
|
||
| // default encoding for writing to flat files - set to charset of this Java virtual machine. | ||
| public static final String DEFAULT_CHARSET = Charset.defaultCharset().name(); |
There was a problem hiding this comment.
There is already a DEFAULT_CHARSET constant in AbstractFileItemWriter. It is that value that should be changed instead of adding a new constant here.
fmbenhassine
added
the
status: waiting-for-reporter
resolves spring-projects#1154 It now matches the encoding scheme of FlatFileItemReader
|
I will update this in the PR. The issue mentions |
cppwfs
force-pushed
the
BATCH-1154
branch
3 times, most recently
from
f3ae970
to
23a7b6b
Compare
fmbenhassine
removed
the
status: waiting-for-reporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1154
It now matches the encoding scheme of FlatFileItemReader