Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename setJobIncrementer to setJobInstanceIncrementer in JdbcJobInstanceDao #3929

Closed
fmbenhassine opened this issue Jun 4, 2021 · 1 comment

Comments

@fmbenhassine
Copy link
Contributor

The DataFieldMaxValueIncrementer jobIncrementer field in JdbcJobInstanceDao is actually an incrementer for job instance IDs and not job IDs (which does not make much sense as there is no Job entity as part of the batch domain classes).

This setter is better renamed to setJobInstanceIncrementer (similar to jobExecutionIncrementer and stepExecutionIncrementer in other DAOs) to be more explicit about the entity IDs it is incrementing. The old setter should be deprecated in favour of the new one.

@parikshitdutta
Copy link
Contributor

Hi @benas, please review submitted PR #3933. I will look forward to your feedback.

Thank you.

@fmbenhassine fmbenhassine modified the milestones: 5.0.0, 5.0.0-M1 Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants