Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThrottleLimitResultQueue apparently dead code, could be removed #3949

Closed
farnetto opened this issue Jun 22, 2021 · 1 comment
Closed

ThrottleLimitResultQueue apparently dead code, could be removed #3949

farnetto opened this issue Jun 22, 2021 · 1 comment
Labels
status: superseded Issues that are superseded by other issues

Comments

@farnetto
Copy link
Contributor

farnetto commented Jun 22, 2021 •
edited

ThrottleLimitResultQueue appears to be an early draft of ResultHolderResultQueue, is apparently completely unused and could be removed to reduce the confusion surrounding multi-threaded step and TaskExecutorRepeatTemplate.
@farnetto farnetto added the status: waiting-for-triage Issues that we did not analyse yet label Jun 22, 2021
@fmbenhassine
Copy link
Contributor

Hi @farnetto ,

While this is true, it does not apply to all unused classes in the code base. Some classes are unused by production code but are provided as support for users, like SystemCommandTasklet, CommandLineJobRunner, etc.

That said, ThrottleLimitResultQueue is indeed unused and does not add any value compared to ResultHolderResultQueue. This class, as well as other unused classes from the org.springframework.batch.repeat package, will be revisited and deprecated as part of #2218. BTW, the entire concurrency model will be revisited as part of v5, I will open a separate issue to explain the reasons for that.

I'm closing this issue as superseded by #2218.

@fmbenhassine fmbenhassine added status: superseded Issues that are superseded by other issues and removed status: waiting-for-triage Issues that we did not analyse yet labels Jun 25, 2021
fmbenhassine added a commit that referenced this issue Oct 12, 2022
@fmbenhassine
Deprecate internal classes related to concurrency in TaskExecutorRepe…
bd9d0d9 
…atTemplate

Related to #3949
Related to #3950
Related to #3951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded Issues that are superseded by other issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fmbenhassine @farnetto