Make ScopeConfiguration publicly accessible #3958
Closed
+53
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a hierarchy of Spring contexts, custom scopes are not visible in child contexts. With this change, it is now possible for users to import the configuration class into child contexts and use job and step scope within them.
|
Thank you for your PR. I agree with you, we should be able to use step/job scoped beans defined in child contexts without any issue. We only need to ensure that the changes suggested here are consistent/coherent with those that will be introduced in #3942 . So I will review your PR in details when addressing #3942 . |
fmbenhassine
pushed a commit
that referenced
this pull request
Sep 3, 2021
When using a hierarchy of Spring contexts, custom scopes are not visible in child contexts. With this change, it is now possible for users to import the configuration class into child contexts and use job and step scope within them. Issue #3958
|
Rebased and merged as fce9a48. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting the batch infrastructure and the actual job configurations into parent and child contexts, respectively, can be beneficial. Interestingly, this is not mentioned in the Spring Batch but Spring Framework documentation.
Unfortunately, custom scopes such as
StepScopeandJobScopeare not visible in child contexts (spring-projects/spring-framework#11749). Thus, the two scopes are only visible in the context that contains the annotation@EnableBatchProcessing, which would be the parent context in the above scenario. This leads to failing jobs in the child contexts if they use step or job scoped beans.With this change, it is possible for users to import
ScopeConfigurationinto child contexts and use job and step scope within them as usual.