New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default encoding to UTF-8 in JdbcExecutionContextDao #3983
Comments
This is a good candidate for v5. UTF-8 seems a reasonable default to me (similar to JEP 400: UTF-8 by default, even if this is for a different purpose). What do you think? This might require increasing the current default value of |
Yes, assuming we want to keep Switching to UTF-8 likely will break code that uses
We specify the length correctly in |
JdbcExecutionContextDao
serializes as ISO-8859-1spring-batch/spring-batch-core/src/main/java/org/springframework/batch/core/repository/dao/JdbcExecutionContextDao.java
Line 77 in d0ab497
This limits us to the ISO-8859-1 repertoire, even simple things like the Euro sign € are not supported. Honestly it is quite confusing that we convert through a binary encoding at all given that
JdbcExecutionContextDao
stores asString
/VARCHAR
/CLOB
/....This would be breaking change for anybody currently using non-ASCII ISO-8859-1 characters.
The text was updated successfully, but these errors were encountered: