Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection's empty data check using CollectionUtils.isEmpty #4021

Closed
ces518 opened this issue Oct 23, 2021 · 0 comments
Closed

Collection's empty data check using CollectionUtils.isEmpty #4021

ces518 opened this issue Oct 23, 2021 · 0 comments
Labels
for: backport-to-4.3.x Issues that will be back-ported to the 4.3.x line in: infrastructure type: enhancement
Milestone
5.0.0-M2

Comments

@ces518
Copy link
Contributor

ces518 commented Oct 23, 2021

Hi, I saw parameterValues check using parameterValues != null in HibernateItemReaderHelper
I don't think it's a good way.
How about using CollectionUtils.isEmpty ?
Only null checking may be a code that relies on an internal implementation, Intellij is also displaying warnings.

thanks. :)

스크린샷 2021-10-23 오후 8 22 37
@ces518 ces518 added the status: waiting-for-triage Issues that we did not analyse yet label Oct 23, 2021
@ces518 ces518 mentioned this issue Oct 23, 2021
Closed
@fmbenhassine fmbenhassine added for: backport-to-4.3.x Issues that will be back-ported to the 4.3.x line in: infrastructure type: enhancement and removed status: waiting-for-triage Issues that we did not analyse yet labels Nov 26, 2021
@fmbenhassine fmbenhassine added this to the 5.0.0-M2 milestone Feb 22, 2022
fmbenhassine pushed a commit that referenced this issue Feb 22, 2022
@ces518 @fmbenhassine
change parameterValues check -> CollectionUtils.isEmpty
721d0bb 
Resolves #4021
@fmbenhassine fmbenhassine mentioned this issue Feb 22, 2022
Closed
lcmarvin pushed a commit to lcmarvin/spring-batch that referenced this issue Apr 16, 2022
@ces518 @lcmarvin
change parameterValues check -> CollectionUtils.isEmpty
bc96a48 
Resolves spring-projects#4021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for: backport-to-4.3.x Issues that will be back-ported to the 4.3.x line in: infrastructure type: enhancement
Projects
None yet
Milestone
5.0.0-M2
Development

No branches or pull requests
2 participants
@fmbenhassine @ces518