Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make JUnit4 dependency optional in spring-batch-test #4033

Closed
murdos opened this issue Dec 8, 2021 · 1 comment
Closed

Make JUnit4 dependency optional in spring-batch-test #4033

murdos opened this issue Dec 8, 2021 · 1 comment
Labels
in: test type: enhancement
Milestone
5.0.0-M3

Comments

@murdos
Copy link

murdos commented Dec 8, 2021

Expected Behavior

spring-batch-test should not have dependency to JUnit4, or should have an optional dependency to JUnit4.

Current Behavior

spring-batch-test has a compile dependency to JUnit4.

Context

In a project using only JUnit5, JUnit4 is in the test classpath when using spring-batch-test.
@murdos murdos added status: waiting-for-triage Issues that we did not analyse yet type: feature labels Dec 8, 2021
@fmbenhassine fmbenhassine added this to the 5.0.0 milestone Dec 23, 2021
@fmbenhassine fmbenhassine removed the status: waiting-for-triage Issues that we did not analyse yet label Dec 23, 2021
danilopiazza added a commit to danilopiazza/spring-batch that referenced this issue Feb 6, 2022
@danilopiazza
Make JUnit 4 an optional dependency in test
6ad8939 
Issue spring-projects#4033
danilopiazza added a commit to danilopiazza/spring-batch that referenced this issue Feb 6, 2022
@danilopiazza
Make JUnit Jupiter a required dependency in test
5d7a6c7 
JUnit Jupiter is now a required dependency in spring-batch-test, whereas
JUnit 4 has become optional.

Issue spring-projects#4033
@danilopiazza danilopiazza mentioned this issue Feb 6, 2022
Closed
@danilopiazza
Copy link
Contributor

Hi, I opened pull request #4054 to address this issue.

danilopiazza added a commit to danilopiazza/spring-batch that referenced this issue Feb 6, 2022
@danilopiazza
Make JUnit Jupiter a required dependency in test
e253efb 
JUnit Jupiter is now a required dependency in spring-batch-test, whereas
JUnit 4 has become optional.

Issue spring-projects#4033
danilopiazza added a commit to danilopiazza/spring-batch that referenced this issue Mar 30, 2022
@danilopiazza
Make JUnit 4 an optional dependency in test
745aa7d 
Issue spring-projects#4033
danilopiazza added a commit to danilopiazza/spring-batch that referenced this issue Mar 30, 2022
@danilopiazza
Make JUnit 4 an optional dependency in test
7c5d686 
Issue spring-projects#4033
@fmbenhassine fmbenhassine modified the milestones: 5.0.0, 5.0.0-M3 Apr 1, 2022
lcmarvin pushed a commit to lcmarvin/spring-batch that referenced this issue Apr 16, 2022
@danilopiazza @lcmarvin
Make JUnit 4 an optional dependency in spring-batch-test
6024dc0 
Resolves spring-projects#4033
@fmbenhassine fmbenhassine changed the title Remove JUnit4 dependency from spring-batch-test Make JUnit4 dependency optional in spring-batch-test May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: test type: enhancement
Projects
None yet
Milestone
5.0.0-M3
Development

No branches or pull requests
3 participants
@murdos @fmbenhassine @danilopiazza