Add @Nullable to StepExecution::endTime #4034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acktsap
force-pushed
the
add-nullable-to-get-end-time
branch
from
0b745e5
to
66289e6
Compare
fmbenhassine
added
in: core
pr-for: enhancement
for: backport-to-4.3.x
|
LGTM. Rebased and merged as dce1525. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StepExecution::endTime is initialized as null at creation. But it's not marked as
@Nullable.When step is in execution, endTime is null. So i used null safe calls but it give me a warning like this.
Marking
@Nullablecan remove the warning.