Remove benign [WARNINGS] from batch build #4066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by: 1) Enabling quiet for doc build so that it, "Shuts off non-error and non-warning messages," so that builders can focus on warnings. 2) Disable missing javadoc warnings. We will handle missing javadoc warnings in subsequent PRs. 3) Fix existing warnings that are in the batch code base. This reduces the number of [WARNING]s from 7171 down to 52
|
LGTM. Rebased and merged as 710d89c. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by:
This reduces the number of [WARNING]s from 7171 down to 52