Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Nullable where appropriate in JobExecution and StepExecution #4077

Closed

Conversation

acktsap
Copy link
Contributor

@acktsap acktsap commented Mar 14, 2022

I've found more nullable field.

Similar with #4034

@acktsap acktsap force-pushed the add-nullable-to-job-execution branch from c8ad644 to d393259 Compare March 18, 2022 04:20
@fmbenhassine fmbenhassine added the for: backport-to-4.3.x Issues that will be back-ported to the 4.3.x line label Apr 14, 2022
@fmbenhassine
Copy link
Contributor

LGTM. startTime is also nullable in StepExecution. I will amend @Nullable on it as well when merging the PR.

@fmbenhassine fmbenhassine added this to the 5.0.0-M3 milestone May 18, 2022
@fmbenhassine
Copy link
Contributor

Rebased and merged as 9ecbf98. Thank you for your contribution!

@fmbenhassine fmbenhassine changed the title Add @Nullable to JobExecution, StepExecution Add @Nullable where appropriate in JobExecution and StepExecution May 18, 2022
@acktsap acktsap deleted the add-nullable-to-job-execution branch February 6, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: backport-to-4.3.x Issues that will be back-ported to the 4.3.x line in: core pr-for: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants