Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing pass for Javadocs #4090

Closed
wants to merge 1 commit into from
Closed

Editing pass for Javadocs #4090

wants to merge 1 commit into from

Conversation

Buzzardo
Copy link

@Buzzardo Buzzardo commented Apr 5, 2022

for org.springframework.batch.core
but not further down that tree.

Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

For more details, please check the contributor guide.
Thank you upfront!

@fmbenhassine fmbenhassine changed the title Editing pass Editing pass for Javadocs Apr 6, 2022
@fmbenhassine fmbenhassine added this to the 5.0.0-M3 milestone Apr 6, 2022
cppwfs
cppwfs reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@cppwfs cppwfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to argue with my comments.
Don't forget to add @author tag and update the copyright to 2022 on files that you update (that don't already have it set to 2022).

spring-batch-core/src/main/java/org/springframework/batch/core/DefaultJobKeyGenerator.java Outdated Show resolved Hide resolved
spring-batch-core/src/main/java/org/springframework/batch/core/ExitStatus.java Show resolved Hide resolved
spring-batch-core/src/main/java/org/springframework/batch/core/ExitStatus.java Outdated Show resolved Hide resolved
spring-batch-core/src/main/java/org/springframework/batch/core/ItemWriteListener.java Show resolved Hide resolved
spring-batch-core/src/main/java/org/springframework/batch/core/JobExecution.java Outdated Show resolved Hide resolved
spring-batch-core/src/main/java/org/springframework/batch/core/JobParametersBuilder.java Outdated Show resolved Hide resolved
spring-batch-core/src/main/java/org/springframework/batch/core/JobParametersBuilder.java Outdated Show resolved Hide resolved
spring-batch-core/src/main/java/org/springframework/batch/core/JobParametersBuilder.java Show resolved Hide resolved
spring-batch-core/src/main/java/org/springframework/batch/core/StepContribution.java Outdated Show resolved Hide resolved
spring-batch-core/src/main/java/org/springframework/batch/core/StepExecution.java Outdated Show resolved Hide resolved
Editing pass
d17464f 
for org.springframework.batch.core
but not further down that tree.
@Buzzardo
Copy link
Author

I was using {@link SomeObject} only for objects within the Batch library, but it makes sense to link to the others, too, I guess.

fmbenhassine pushed a commit that referenced this pull request May 5, 2022
@fmbenhassine
Editing pass for Javadocs
d00cd94 
Update javadocs of org.springframework.batch.core
but not further down that tree.

Issue #4090
@fmbenhassine
Copy link
Contributor

Rebased and merged as d00cd94. Thank you @Buzzardo !

fmbenhassine pushed a commit to fmbenhassine/spring-batch that referenced this pull request May 9, 2022
@fmbenhassine
Editing pass for Javadocs
e2f6cd9 
Update javadocs of org.springframework.batch.core
but not further down that tree.

Issue spring-projects#4090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppwfs cppwfs cppwfs left review comments

Assignees
No one assigned
Labels
in: documentation pr-for: enhancement
Projects
None yet
Milestone
5.0.0-M3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Buzzardo @fmbenhassine @cppwfs